Linux Btrfs filesystem development
 help / color / mirror / Atom feed
* Re: [PATCH 1/2] treewide: fix memory corruptions when TASK_COMM_LEN != 16
       [not found]                   ` <alpine.LNX.2.01.1202222303190.15465@frira.zrqbmnf.qr>
@ 2012-02-23  9:57                     ` Andrew Morton
  2012-02-23 11:19                       ` Jan Engelhardt
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2012-02-23  9:57 UTC (permalink / raw)
  To: Jan Engelhardt; +Cc: linux-kernel, linux-btrfs

On Thu, 23 Feb 2012 10:09:33 +0100 (CET) Jan Engelhardt <jengelh@medozas.de> wrote:

> On Wednesday 2012-02-22 21:58, Andrew Morton wrote:
> 
> >On Wed, 22 Feb 2012 13:48:08 +0100 (CET)
> >Jan Engelhardt <jengelh@medozas.de> wrote:
> >
> >> task: provide a larger task command buffer
> >
> ><scratches head>
> >
> >Why are we bothering ourselves about this?
> 
> Some prefer to know what's going on in the system. Every other or 
> so kernel release there are some new happy kthreads, such as
> 
> 24930 ?        S      0:00  \_ [btrfs-endio-1]
> 24931 ?        S      0:00  \_ [btrfs-endio-met]
> 24932 ?        S      0:00  \_ [btrfs-endio-met]
> 24933 ?        S      0:00  \_ [btrfs-endio-wri]
> 24934 ?        S      0:00  \_ [btrfs-freespace]
> 
> at which point one is curious to find out the rest of the met and why 
> there are two of them. If expanded one actually sees they are different 
> kthreads (rather than just per-cpu instances for a WQ, for example)
> 
> $ grep Name /proc/{29431,29432}/stat*
> /proc/29431/status:Name: btrfs-endio-meta-1
> /proc/29432/status:Name: btrfs-endio-meta-write-1
> 
> That's all.

doh.  The fix for that is to have less clueless btrfs developers.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] treewide: fix memory corruptions when TASK_COMM_LEN != 16
  2012-02-23  9:57                     ` [PATCH 1/2] treewide: fix memory corruptions when TASK_COMM_LEN != 16 Andrew Morton
@ 2012-02-23 11:19                       ` Jan Engelhardt
  2012-02-23 17:30                         ` Andrew Morton
  0 siblings, 1 reply; 4+ messages in thread
From: Jan Engelhardt @ 2012-02-23 11:19 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, linux-btrfs


On Thursday 2012-02-23 10:57, Andrew Morton wrote:
>>
But there's more,
>> 
>> 24931 ?        S      0:00  \_ [btrfs-endio-met]
                               \_ [kconservative/5]
                               \_ [ext4-dio-unwrit]
>> 
>> [with a wondersome patch:] $ grep Name /proc/{29431,29432}/stat*
>> /proc/29431/status:Name: btrfs-endio-meta-1
>> /proc/29432/status:Name: btrfs-endio-meta-write-1
                      Name: kconservative/512
                      Name: ext4-dio-unwritten
>
>doh.  The fix for that is to have less clueless btrfs developers.

And truncate their names to SUNWbtfs, ORCLintg and EXT4diou?
I think not :)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] treewide: fix memory corruptions when TASK_COMM_LEN != 16
  2012-02-23 11:19                       ` Jan Engelhardt
@ 2012-02-23 17:30                         ` Andrew Morton
  2012-02-23 21:59                           ` Jan Engelhardt
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2012-02-23 17:30 UTC (permalink / raw)
  To: Jan Engelhardt; +Cc: linux-kernel, linux-btrfs

On Thu, 23 Feb 2012 12:19:28 +0100 (CET) Jan Engelhardt <jengelh@medozas.de> wrote:

> 
> On Thursday 2012-02-23 10:57, Andrew Morton wrote:
> >>
> But there's more,
> >> 
> >> 24931 ?        S      0:00  \_ [btrfs-endio-met]
>                                \_ [kconservative/5]
>                                \_ [ext4-dio-unwrit]
> >> 
> >> [with a wondersome patch:] $ grep Name /proc/{29431,29432}/stat*
> >> /proc/29431/status:Name: btrfs-endio-meta-1
> >> /proc/29432/status:Name: btrfs-endio-meta-write-1
>                       Name: kconservative/512
>                       Name: ext4-dio-unwritten
> >
> >doh.  The fix for that is to have less clueless btrfs developers.
> 
> And truncate their names to SUNWbtfs, ORCLintg and EXT4diou?
> I think not :)

Teach ps(1) to look in /proc/pid/status for kernel threads?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] treewide: fix memory corruptions when TASK_COMM_LEN != 16
  2012-02-23 17:30                         ` Andrew Morton
@ 2012-02-23 21:59                           ` Jan Engelhardt
  0 siblings, 0 replies; 4+ messages in thread
From: Jan Engelhardt @ 2012-02-23 21:59 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, linux-btrfs


On Thursday 2012-02-23 18:30, Andrew Morton wrote:
>
>Teach ps(1) to look in /proc/pid/status for kernel threads?

To what end? The name in /proc/pid/status was also limited to
TASK_COMM_LEN.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-02-23 21:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1327183785-27023-1-git-send-email-jengelh@medozas.de>
     [not found] ` <20120124135443.2772d455.akpm@linux-foundation.org>
     [not found]   ` <alpine.LNX.2.01.1201250121260.20692@frira.zrqbmnf.qr>
     [not found]     ` <20120131172334.7f26f164.akpm@linux-foundation.org>
     [not found]       ` <alpine.LNX.2.01.1202010224510.29848@frira.zrqbmnf.qr>
     [not found]         ` <20120131174914.8ce5291d.akpm@linux-foundation.org>
     [not found]           ` <alpine.LNX.2.01.1202010257240.29848@frira.zrqbmnf.qr>
     [not found]             ` <20120131190109.b53347fd.akpm@linux-foundation.org>
     [not found]               ` <alpine.LNX.2.01.1202221343530.10125@frira.zrqbmnf.qr>
     [not found]                 ` <20120222125810.50cd5789.akpm@linux-foundation.org>
     [not found]                   ` <alpine.LNX.2.01.1202222303190.15465@frira.zrqbmnf.qr>
2012-02-23  9:57                     ` [PATCH 1/2] treewide: fix memory corruptions when TASK_COMM_LEN != 16 Andrew Morton
2012-02-23 11:19                       ` Jan Engelhardt
2012-02-23 17:30                         ` Andrew Morton
2012-02-23 21:59                           ` Jan Engelhardt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox