From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 12/16] btrfs: track running balance in a simpler way
Date: Fri, 27 Apr 2018 18:10:12 +0200 [thread overview]
Message-ID: <20180427161012.GE21272@twin.jikos.cz> (raw)
In-Reply-To: <2e28020f-ef28-ee43-d9e3-1c74c03a472d@oracle.com>
On Fri, Apr 27, 2018 at 10:10:24AM +0800, Anand Jain wrote:
>
>
> On 04/20/2018 12:33 AM, David Sterba wrote:
> > Currently fs_info::balance_running is 0 or 1 and does not use the
> > semantics of atomics. The pause and cancel check for 0, that can happen
> > only after __btrfs_balance exits for whatever reason.
> >
> > Parallel calls to balance ioctl may enter btrfs_ioctl_balance multiple
> > times but will block on the balance_mutex that protects the
> > fs_info::flags bit.
> >
> > Signed-off-by: David Sterba <dsterba@suse.com>
>
> Though it appears to me that we could optimize the lock and atomic bit
> usage a little more, however it can be taken for the next round of
> cleanups. So for now..
>
> Reviewed-by: Anand Jain <anand.jain@oracle.com>
Thanks, patches updated.
next prev parent reply other threads:[~2018-04-27 16:12 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 16:33 [PATCH v2 00/16] Kill fs_info::volume_mutex David Sterba
2018-04-19 16:33 ` [PATCH v2 01/16] btrfs: squeeze btrfs_dev_replace_continue_on_mount to its caller David Sterba
2018-04-19 16:33 ` [PATCH v2 02/16] btrfs: make success path out of btrfs_init_dev_replace_tgtdev more clear David Sterba
2018-04-19 16:33 ` [PATCH v2 03/16] btrfs: export and rename free_device David Sterba
2018-04-19 16:33 ` [PATCH v2 04/16] btrfs: move btrfs_init_dev_replace_tgtdev to dev-replace.c and make static David Sterba
2018-04-19 16:33 ` [PATCH v2 05/16] btrfs: move volume_mutex to callers of btrfs_rm_device David Sterba
2018-04-19 16:33 ` [PATCH v2 06/16] btrfs: move clearing of EXCL_OP out of __cancel_balance David Sterba
2018-04-20 7:02 ` Nikolay Borisov
2018-04-20 7:35 ` Anand Jain
2018-04-19 16:33 ` [PATCH v2 07/16] btrfs: add proper safety check before resuming dev-replace David Sterba
2018-04-20 7:04 ` Nikolay Borisov
2018-04-20 7:36 ` Anand Jain
2018-04-19 16:33 ` [PATCH v2 08/16] btrfs: add sanity check when resuming balance after mount David Sterba
2018-04-20 7:38 ` Anand Jain
2018-04-19 16:33 ` [PATCH v2 09/16] btrfs: cleanup helpers that reset balance state David Sterba
2018-04-20 7:07 ` Nikolay Borisov
2018-04-20 11:28 ` David Sterba
2018-04-20 9:04 ` Anand Jain
2018-04-19 16:33 ` [PATCH v2 10/16] btrfs: remove wrong use of volume_mutex from btrfs_dev_replace_start David Sterba
2018-04-19 16:33 ` [PATCH v2 11/16] btrfs: kill btrfs_fs_info::volume_mutex David Sterba
2018-04-19 16:33 ` [PATCH v2 12/16] btrfs: track running balance in a simpler way David Sterba
2018-04-20 7:52 ` Anand Jain
2018-04-20 11:58 ` David Sterba
2018-04-20 12:19 ` David Sterba
2018-04-20 13:32 ` Anand Jain
2018-04-27 2:10 ` Anand Jain
2018-04-27 16:10 ` David Sterba [this message]
2018-04-19 16:33 ` [PATCH v2 13/16] btrfs: move and comment read-only check in btrfs_cancel_balance David Sterba
2018-04-20 9:13 ` Anand Jain
2018-04-20 11:59 ` David Sterba
2018-04-20 12:06 ` [PATCH v2.1 " David Sterba
2018-04-27 2:02 ` Anand Jain
2018-04-19 16:33 ` [PATCH v2 14/16] btrfs: drop lock parameter from update_ioctl_balance_args and rename David Sterba
2018-04-20 9:21 ` Anand Jain
2018-04-19 16:33 ` [PATCH v2 15/16] btrfs: use mutex in btrfs_resume_balance_async David Sterba
2018-04-20 9:25 ` Anand Jain
2018-04-19 16:33 ` [PATCH v2 16/16] btrfs: open code set_balance_control David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427161012.GE21272@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox