From: David Sterba <dsterba@suse.cz>
To: Jeff Mahoney <jeffm@suse.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.com
Subject: Re: [PATCH 3/3] btrfs-progs: build: use m4_flatten instead of m4_chomp
Date: Sun, 29 Apr 2018 12:13:10 +0200 [thread overview]
Message-ID: <20180429101309.GN21272@twin.jikos.cz> (raw)
In-Reply-To: <75b17e5e-520f-7c23-b592-047e2b150474@suse.com>
On Fri, Apr 27, 2018 at 03:18:17PM -0400, Jeff Mahoney wrote:
> On 4/27/18 2:56 PM, jeffm@suse.com wrote:
> > From: Jeff Mahoney <jeffm@suse.com>
> >
> > Commit 2e1932e6a38 (btrfs-progs: build: simplify version tracking)
> > started m4_chomp to strip the newlines from the version file. m4_chomp
> > was introduced in autoconf 2.64 but SLE11 ships with autoconf 2.63.
> > For purposes of just stripping the newline, m4_flatten is sufficient.
>
> Scratch that. The previous patch also requires autoconf 2.64.
I wanted to avoid shell tricks, but this should work everywhere:
m4_esyscmd([echo -n $(cat VERSION)])
next prev parent reply other threads:[~2018-04-29 10:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 18:56 [PATCH 0/3] btrfs-progs: build on SLE11 jeffm
2018-04-27 18:56 ` [PATCH 1/3] btrfs-progs: convert: fix support for e2fsprogs < 1.42 jeffm
2018-04-27 18:56 ` [PATCH 2/3] btrfs-progs: build: detect whether -std=gnu90 is supported jeffm
2018-04-27 18:56 ` [PATCH 3/3] btrfs-progs: build: use m4_flatten instead of m4_chomp jeffm
2018-04-27 19:18 ` Jeff Mahoney
2018-04-29 10:13 ` David Sterba [this message]
2018-04-29 13:19 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180429101309.GN21272@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox