From: Jeff Mahoney <jeffm@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: dsterba@suse.com
Subject: Re: [PATCH 3/3] btrfs-progs: build: use m4_flatten instead of m4_chomp
Date: Fri, 27 Apr 2018 15:18:17 -0400 [thread overview]
Message-ID: <75b17e5e-520f-7c23-b592-047e2b150474@suse.com> (raw)
In-Reply-To: <20180427185637.16642-4-jeffm@suse.com>
On 4/27/18 2:56 PM, jeffm@suse.com wrote:
> From: Jeff Mahoney <jeffm@suse.com>
>
> Commit 2e1932e6a38 (btrfs-progs: build: simplify version tracking)
> started m4_chomp to strip the newlines from the version file. m4_chomp
> was introduced in autoconf 2.64 but SLE11 ships with autoconf 2.63.
> For purposes of just stripping the newline, m4_flatten is sufficient.
Scratch that. The previous patch also requires autoconf 2.64.
-Jeff
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 17880206..a0cebf15 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1,5 +1,5 @@
> AC_INIT([btrfs-progs],
> - m4_chomp(m4_include([VERSION])),
> + m4_flatten(m4_include([VERSION])),
> [linux-btrfs@vger.kernel.org],,
> [http://btrfs.wiki.kernel.org])
>
>
--
Jeff Mahoney
SUSE Labs
next prev parent reply other threads:[~2018-04-27 19:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 18:56 [PATCH 0/3] btrfs-progs: build on SLE11 jeffm
2018-04-27 18:56 ` [PATCH 1/3] btrfs-progs: convert: fix support for e2fsprogs < 1.42 jeffm
2018-04-27 18:56 ` [PATCH 2/3] btrfs-progs: build: detect whether -std=gnu90 is supported jeffm
2018-04-27 18:56 ` [PATCH 3/3] btrfs-progs: build: use m4_flatten instead of m4_chomp jeffm
2018-04-27 19:18 ` Jeff Mahoney [this message]
2018-04-29 10:13 ` David Sterba
2018-04-29 13:19 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75b17e5e-520f-7c23-b592-047e2b150474@suse.com \
--to=jeffm@suse.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox