From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: trace: Remove unnecessary fs_info parameter for btrfs__reserve_extent event class
Date: Tue, 1 May 2018 14:58:14 +0200 [thread overview]
Message-ID: <20180501125814.GP21272@twin.jikos.cz> (raw)
In-Reply-To: <fd2d7c13-2999-bb7a-99fc-d8b6839f8558@gmx.com>
On Sun, Apr 29, 2018 at 08:33:49AM +0800, Qu Wenruo wrote:
>
>
> On 2018年04月29日 01:45, David Sterba wrote:
> > On Sat, Apr 28, 2018 at 06:42:06PM +0200, David Sterba wrote:
> >> On Thu, Apr 26, 2018 at 02:24:25PM +0800, Qu Wenruo wrote:
> >>> fs_info can be extracted from btrfs_block_group_cache, and all
> >>> btrfs_block_group_cache is created by btrfs_create_block_group_cache()
> >>> with fs_info initialized, no need to worry about NULL pointer
> >>> dereference.
> >>
> >> Famous last words.
> >
> > And it's a false alert, it's caused by another patch yet to be
> > identified.
>
> Yep, I also spent serval minutes to find this out.
> As in that test there is nothing related to btrfs_reserve_extent() trace
> event.
Ok, found it "btrfs: simplify counting number of eb pages", will be
removed from misc-next.
prev parent reply other threads:[~2018-05-01 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 6:24 [PATCH] btrfs: trace: Remove unnecessary fs_info parameter for btrfs__reserve_extent event class Qu Wenruo
2018-04-26 6:27 ` Nikolay Borisov
2018-04-26 13:06 ` David Sterba
2018-04-28 16:42 ` David Sterba
2018-04-28 17:45 ` David Sterba
2018-04-29 0:33 ` Qu Wenruo
2018-05-01 12:58 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501125814.GP21272@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox