public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: trace: Remove unnecessary fs_info parameter for btrfs__reserve_extent event class
Date: Sun, 29 Apr 2018 08:33:49 +0800	[thread overview]
Message-ID: <fd2d7c13-2999-bb7a-99fc-d8b6839f8558@gmx.com> (raw)
In-Reply-To: <20180428174511.GL21272@twin.jikos.cz>


[-- Attachment #1.1: Type: text/plain, Size: 888 bytes --]



On 2018年04月29日 01:45, David Sterba wrote:
> On Sat, Apr 28, 2018 at 06:42:06PM +0200, David Sterba wrote:
>> On Thu, Apr 26, 2018 at 02:24:25PM +0800, Qu Wenruo wrote:
>>> fs_info can be extracted from btrfs_block_group_cache, and all
>>> btrfs_block_group_cache is created by btrfs_create_block_group_cache()
>>> with fs_info initialized, no need to worry about NULL pointer
>>> dereference.
>>
>> Famous last words.
> 
> And it's a false alert, it's caused by another patch yet to be
> identified.

Yep, I also spent serval minutes to find this out.
As in that test there is nothing related to btrfs_reserve_extent() trace
event.

Thanks,
Qu

> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-04-29  0:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26  6:24 [PATCH] btrfs: trace: Remove unnecessary fs_info parameter for btrfs__reserve_extent event class Qu Wenruo
2018-04-26  6:27 ` Nikolay Borisov
2018-04-26 13:06   ` David Sterba
2018-04-28 16:42 ` David Sterba
2018-04-28 17:45   ` David Sterba
2018-04-29  0:33     ` Qu Wenruo [this message]
2018-05-01 12:58       ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd2d7c13-2999-bb7a-99fc-d8b6839f8558@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox