Linux Btrfs filesystem development
 help / color / mirror / Atom feed
* [PATCH] btrfs-progs: check: add experimental flag for lowmem mode
@ 2018-07-03 11:42 David Disseldorp
  2018-07-04  1:19 ` Su Yue
  2018-07-04 11:55 ` David Sterba
  0 siblings, 2 replies; 3+ messages in thread
From: David Disseldorp @ 2018-07-03 11:42 UTC (permalink / raw)
  To: linux-btrfs; +Cc: David Disseldorp

The experimental flag is already carried in the manpage, but was removed
from the btrfs check usage message as part of refactoring via
87c1bd13c1fca430c3dbf0da62e9aa33bde609c8. Add it back.

Signed-off-by: David Disseldorp <ddiss@suse.de>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
---
 check/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/check/main.c b/check/main.c
index 3190b5d4..9aca0c09 100644
--- a/check/main.c
+++ b/check/main.c
@@ -9386,7 +9386,7 @@ const char * const cmd_check_usage[] = {
 	"                            original - read inodes and extents to memory (requires",
 	"                                       more memory, does less IO)",
 	"                            lowmem   - try to use less memory but read blocks again",
-	"                                       when needed",
+	"                                       when needed (experimental)",
 	"--check-data-csum           verify checksums of data blocks",
 	"-Q|--qgroup-report          print a report on qgroup consistency",
 	"-E|--subvol-extents <subvolid>",
-- 
2.13.7


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] btrfs-progs: check: add experimental flag for lowmem mode
  2018-07-03 11:42 [PATCH] btrfs-progs: check: add experimental flag for lowmem mode David Disseldorp
@ 2018-07-04  1:19 ` Su Yue
  2018-07-04 11:55 ` David Sterba
  1 sibling, 0 replies; 3+ messages in thread
From: Su Yue @ 2018-07-04  1:19 UTC (permalink / raw)
  To: David Disseldorp, linux-btrfs



On 07/03/2018 07:42 PM, David Disseldorp wrote:
> The experimental flag is already carried in the manpage, but was removed
> from the btrfs check usage message as part of refactoring via
> 87c1bd13c1fca430c3dbf0da62e9aa33bde609c8. Add it back.
> 
> Signed-off-by: David Disseldorp <ddiss@suse.de>
> Reviewed-by: Nikolay Borisov <nborisov@suse.com>

Reviewed-by: Su Yue <suy.fnst@cn.fujitsu.com>
> ---
>   check/main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/check/main.c b/check/main.c
> index 3190b5d4..9aca0c09 100644
> --- a/check/main.c
> +++ b/check/main.c
> @@ -9386,7 +9386,7 @@ const char * const cmd_check_usage[] = {
>   	"                            original - read inodes and extents to memory (requires",
>   	"                                       more memory, does less IO)",
>   	"                            lowmem   - try to use less memory but read blocks again",
> -	"                                       when needed",
> +	"                                       when needed (experimental)",
>   	"--check-data-csum           verify checksums of data blocks",
>   	"-Q|--qgroup-report          print a report on qgroup consistency",
>   	"-E|--subvol-extents <subvolid>",
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] btrfs-progs: check: add experimental flag for lowmem mode
  2018-07-03 11:42 [PATCH] btrfs-progs: check: add experimental flag for lowmem mode David Disseldorp
  2018-07-04  1:19 ` Su Yue
@ 2018-07-04 11:55 ` David Sterba
  1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2018-07-04 11:55 UTC (permalink / raw)
  To: David Disseldorp; +Cc: linux-btrfs

On Tue, Jul 03, 2018 at 01:42:37PM +0200, David Disseldorp wrote:
> The experimental flag is already carried in the manpage, but was removed
> from the btrfs check usage message as part of refactoring via
> 87c1bd13c1fca430c3dbf0da62e9aa33bde609c8. Add it back.
> 
> Signed-off-by: David Disseldorp <ddiss@suse.de>
> Reviewed-by: Nikolay Borisov <nborisov@suse.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-07-04 11:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-03 11:42 [PATCH] btrfs-progs: check: add experimental flag for lowmem mode David Disseldorp
2018-07-04  1:19 ` Su Yue
2018-07-04 11:55 ` David Sterba

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox