From: David Sterba <dsterba@suse.cz>
To: "Gu, Jinxiang" <gujx@cn.fujitsu.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [bug report] btrfs: Add type check when reading a chunk
Date: Thu, 19 Jul 2018 11:22:01 +0200 [thread overview]
Message-ID: <20180719092201.GD26141@twin.jikos.cz> (raw)
In-Reply-To: <516DDBE5B1D92D42BCF7A2E37F045A5D01A8A37CB1@G08CNEXMBPEKD02.g08.fujitsu.local>
On Thu, Jul 19, 2018 at 08:18:25AM +0000, Gu, Jinxiang wrote:
>
>
> > -----Original Message-----
> > From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> > Sent: Thursday, July 19, 2018 4:11 PM
> > To: Gu, Jinxiang/顾 金香 <gujx@cn.fujitsu.com>
> > Cc: linux-btrfs@vger.kernel.org
> > Subject: [bug report] btrfs: Add type check when reading a chunk
> >
> > Hello Gu Jinxiang,
> >
> > The patch 72e75ed03c8d: "btrfs: Add type check when reading a chunk"
> > from Jul 4, 2018, leads to the following static checker warning:
> >
> > fs/btrfs/volumes.c:6388 btrfs_check_chunk_valid()
> > warn: AND to zero '0x4 & 0x1'
> >
> > fs/btrfs/volumes.c
> > 6356 if (!is_power_of_2(stripe_len) || stripe_len != BTRFS_STRIPE_LEN) {
> > 6357 btrfs_err(fs_info, "invalid chunk stripe length: %llu",
> > 6358 stripe_len);
> > 6359 return -EIO;
> > 6360 }
> > 6361 if (~(BTRFS_BLOCK_GROUP_TYPE_MASK | BTRFS_BLOCK_GROUP_PROFILE_MASK) &
> > 6362 type) {
> > 6363 btrfs_err(fs_info, "unrecognized chunk type: %llu",
> > 6364 ~(BTRFS_BLOCK_GROUP_TYPE_MASK |
> > 6365 BTRFS_BLOCK_GROUP_PROFILE_MASK) &
> > 6366 btrfs_chunk_type(leaf, chunk));
> > 6367 return -EIO;
> > 6368 }
> > 6369
> > 6370 if ((type & BTRFS_BLOCK_GROUP_TYPE_MASK) == 0) {
> > 6371 btrfs_err(fs_info, "missing chunk type flag: %llu", type);
> > 6372 return -EIO;
> > 6373 }
> > 6374
> > 6375 if ((type & BTRFS_BLOCK_GROUP_SYSTEM) &&
> > 6376 (type & (BTRFS_BLOCK_GROUP_METADATA | BTRFS_BLOCK_GROUP_DATA))) {
> > 6377 btrfs_err(fs_info,
> > 6378 "system chunk with data or metadata type: %llu", type);
> > 6379 return -EIO;
> > 6380 }
> > 6381
> > 6382 features = btrfs_super_incompat_flags(fs_info->super_copy);
> > 6383 if (features & BTRFS_FEATURE_INCOMPAT_MIXED_GROUPS)
> > 6384 mixed = 1;
> > 6385
> > 6386 if (!mixed) {
> > 6387 if (type &
> > 6388 (BTRFS_BLOCK_GROUP_METADATA & BTRFS_BLOCK_GROUP_DATA)) {
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > Was this supposed to be | or perhaps check that both are set?
> Yes. It should be |.
> Thank you, I'll send a patch to fix it.
Not needed, I'll fix the patch directly.
next prev parent reply other threads:[~2018-07-19 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 8:10 [bug report] btrfs: Add type check when reading a chunk Dan Carpenter
2018-07-19 8:18 ` Gu, Jinxiang
2018-07-19 9:22 ` David Sterba [this message]
2018-07-19 10:14 ` David Sterba
2018-07-20 5:32 ` Gu, Jinxiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719092201.GD26141@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dan.carpenter@oracle.com \
--cc=gujx@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox