* [bug report] btrfs: Add type check when reading a chunk
@ 2018-07-19 8:10 Dan Carpenter
2018-07-19 8:18 ` Gu, Jinxiang
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2018-07-19 8:10 UTC (permalink / raw)
To: gujx; +Cc: linux-btrfs
Hello Gu Jinxiang,
The patch 72e75ed03c8d: "btrfs: Add type check when reading a chunk"
from Jul 4, 2018, leads to the following static checker warning:
fs/btrfs/volumes.c:6388 btrfs_check_chunk_valid()
warn: AND to zero '0x4 & 0x1'
fs/btrfs/volumes.c
6356 if (!is_power_of_2(stripe_len) || stripe_len != BTRFS_STRIPE_LEN) {
6357 btrfs_err(fs_info, "invalid chunk stripe length: %llu",
6358 stripe_len);
6359 return -EIO;
6360 }
6361 if (~(BTRFS_BLOCK_GROUP_TYPE_MASK | BTRFS_BLOCK_GROUP_PROFILE_MASK) &
6362 type) {
6363 btrfs_err(fs_info, "unrecognized chunk type: %llu",
6364 ~(BTRFS_BLOCK_GROUP_TYPE_MASK |
6365 BTRFS_BLOCK_GROUP_PROFILE_MASK) &
6366 btrfs_chunk_type(leaf, chunk));
6367 return -EIO;
6368 }
6369
6370 if ((type & BTRFS_BLOCK_GROUP_TYPE_MASK) == 0) {
6371 btrfs_err(fs_info, "missing chunk type flag: %llu", type);
6372 return -EIO;
6373 }
6374
6375 if ((type & BTRFS_BLOCK_GROUP_SYSTEM) &&
6376 (type & (BTRFS_BLOCK_GROUP_METADATA | BTRFS_BLOCK_GROUP_DATA))) {
6377 btrfs_err(fs_info,
6378 "system chunk with data or metadata type: %llu", type);
6379 return -EIO;
6380 }
6381
6382 features = btrfs_super_incompat_flags(fs_info->super_copy);
6383 if (features & BTRFS_FEATURE_INCOMPAT_MIXED_GROUPS)
6384 mixed = 1;
6385
6386 if (!mixed) {
6387 if (type &
6388 (BTRFS_BLOCK_GROUP_METADATA & BTRFS_BLOCK_GROUP_DATA)) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Was this supposed to be | or perhaps check that both are set?
6389 btrfs_err(fs_info,
6390 "mixed chunk type in non-mixed mode: %llu", type);
6391 return -EIO;
6392 }
6393 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [bug report] btrfs: Add type check when reading a chunk
2018-07-19 8:10 [bug report] btrfs: Add type check when reading a chunk Dan Carpenter
@ 2018-07-19 8:18 ` Gu, Jinxiang
2018-07-19 9:22 ` David Sterba
0 siblings, 1 reply; 5+ messages in thread
From: Gu, Jinxiang @ 2018-07-19 8:18 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-btrfs@vger.kernel.org
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 2831 bytes --]
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Thursday, July 19, 2018 4:11 PM
> To: Gu, Jinxiang/¹Ë ½ðÏã <gujx@cn.fujitsu.com>
> Cc: linux-btrfs@vger.kernel.org
> Subject: [bug report] btrfs: Add type check when reading a chunk
>
> Hello Gu Jinxiang,
>
> The patch 72e75ed03c8d: "btrfs: Add type check when reading a chunk"
> from Jul 4, 2018, leads to the following static checker warning:
>
> fs/btrfs/volumes.c:6388 btrfs_check_chunk_valid()
> warn: AND to zero '0x4 & 0x1'
>
> fs/btrfs/volumes.c
> 6356 if (!is_power_of_2(stripe_len) || stripe_len != BTRFS_STRIPE_LEN) {
> 6357 btrfs_err(fs_info, "invalid chunk stripe length: %llu",
> 6358 stripe_len);
> 6359 return -EIO;
> 6360 }
> 6361 if (~(BTRFS_BLOCK_GROUP_TYPE_MASK | BTRFS_BLOCK_GROUP_PROFILE_MASK) &
> 6362 type) {
> 6363 btrfs_err(fs_info, "unrecognized chunk type: %llu",
> 6364 ~(BTRFS_BLOCK_GROUP_TYPE_MASK |
> 6365 BTRFS_BLOCK_GROUP_PROFILE_MASK) &
> 6366 btrfs_chunk_type(leaf, chunk));
> 6367 return -EIO;
> 6368 }
> 6369
> 6370 if ((type & BTRFS_BLOCK_GROUP_TYPE_MASK) == 0) {
> 6371 btrfs_err(fs_info, "missing chunk type flag: %llu", type);
> 6372 return -EIO;
> 6373 }
> 6374
> 6375 if ((type & BTRFS_BLOCK_GROUP_SYSTEM) &&
> 6376 (type & (BTRFS_BLOCK_GROUP_METADATA | BTRFS_BLOCK_GROUP_DATA))) {
> 6377 btrfs_err(fs_info,
> 6378 "system chunk with data or metadata type: %llu", type);
> 6379 return -EIO;
> 6380 }
> 6381
> 6382 features = btrfs_super_incompat_flags(fs_info->super_copy);
> 6383 if (features & BTRFS_FEATURE_INCOMPAT_MIXED_GROUPS)
> 6384 mixed = 1;
> 6385
> 6386 if (!mixed) {
> 6387 if (type &
> 6388 (BTRFS_BLOCK_GROUP_METADATA & BTRFS_BLOCK_GROUP_DATA)) {
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Was this supposed to be | or perhaps check that both are set?
Yes. It should be |.
Thank you, I'll send a patch to fix it.
>
> 6389 btrfs_err(fs_info,
> 6390 "mixed chunk type in non-mixed mode: %llu", type);
> 6391 return -EIO;
> 6392 }
> 6393 }
>
> regards,
> dan carpenter
>
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±ý»k~ÏâžØ^n‡r¡ö¦zË\x1aëh™¨èÚ&£ûàz¿äz¹Þ—ú+€Ê+zf£¢·hšˆ§~††Ûiÿÿïêÿ‘êçz_è®\x0fæj:+v‰¨þ)ߣøm
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [bug report] btrfs: Add type check when reading a chunk
2018-07-19 8:18 ` Gu, Jinxiang
@ 2018-07-19 9:22 ` David Sterba
2018-07-19 10:14 ` David Sterba
0 siblings, 1 reply; 5+ messages in thread
From: David Sterba @ 2018-07-19 9:22 UTC (permalink / raw)
To: Gu, Jinxiang; +Cc: Dan Carpenter, linux-btrfs@vger.kernel.org
On Thu, Jul 19, 2018 at 08:18:25AM +0000, Gu, Jinxiang wrote:
>
>
> > -----Original Message-----
> > From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> > Sent: Thursday, July 19, 2018 4:11 PM
> > To: Gu, Jinxiang/顾 金香 <gujx@cn.fujitsu.com>
> > Cc: linux-btrfs@vger.kernel.org
> > Subject: [bug report] btrfs: Add type check when reading a chunk
> >
> > Hello Gu Jinxiang,
> >
> > The patch 72e75ed03c8d: "btrfs: Add type check when reading a chunk"
> > from Jul 4, 2018, leads to the following static checker warning:
> >
> > fs/btrfs/volumes.c:6388 btrfs_check_chunk_valid()
> > warn: AND to zero '0x4 & 0x1'
> >
> > fs/btrfs/volumes.c
> > 6356 if (!is_power_of_2(stripe_len) || stripe_len != BTRFS_STRIPE_LEN) {
> > 6357 btrfs_err(fs_info, "invalid chunk stripe length: %llu",
> > 6358 stripe_len);
> > 6359 return -EIO;
> > 6360 }
> > 6361 if (~(BTRFS_BLOCK_GROUP_TYPE_MASK | BTRFS_BLOCK_GROUP_PROFILE_MASK) &
> > 6362 type) {
> > 6363 btrfs_err(fs_info, "unrecognized chunk type: %llu",
> > 6364 ~(BTRFS_BLOCK_GROUP_TYPE_MASK |
> > 6365 BTRFS_BLOCK_GROUP_PROFILE_MASK) &
> > 6366 btrfs_chunk_type(leaf, chunk));
> > 6367 return -EIO;
> > 6368 }
> > 6369
> > 6370 if ((type & BTRFS_BLOCK_GROUP_TYPE_MASK) == 0) {
> > 6371 btrfs_err(fs_info, "missing chunk type flag: %llu", type);
> > 6372 return -EIO;
> > 6373 }
> > 6374
> > 6375 if ((type & BTRFS_BLOCK_GROUP_SYSTEM) &&
> > 6376 (type & (BTRFS_BLOCK_GROUP_METADATA | BTRFS_BLOCK_GROUP_DATA))) {
> > 6377 btrfs_err(fs_info,
> > 6378 "system chunk with data or metadata type: %llu", type);
> > 6379 return -EIO;
> > 6380 }
> > 6381
> > 6382 features = btrfs_super_incompat_flags(fs_info->super_copy);
> > 6383 if (features & BTRFS_FEATURE_INCOMPAT_MIXED_GROUPS)
> > 6384 mixed = 1;
> > 6385
> > 6386 if (!mixed) {
> > 6387 if (type &
> > 6388 (BTRFS_BLOCK_GROUP_METADATA & BTRFS_BLOCK_GROUP_DATA)) {
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > Was this supposed to be | or perhaps check that both are set?
> Yes. It should be |.
> Thank you, I'll send a patch to fix it.
Not needed, I'll fix the patch directly.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [bug report] btrfs: Add type check when reading a chunk
2018-07-19 9:22 ` David Sterba
@ 2018-07-19 10:14 ` David Sterba
2018-07-20 5:32 ` Gu, Jinxiang
0 siblings, 1 reply; 5+ messages in thread
From: David Sterba @ 2018-07-19 10:14 UTC (permalink / raw)
To: dsterba, Gu, Jinxiang, Dan Carpenter, linux-btrfs@vger.kernel.org
On Thu, Jul 19, 2018 at 11:22:01AM +0200, David Sterba wrote:
> On Thu, Jul 19, 2018 at 08:18:25AM +0000, Gu, Jinxiang wrote:
> >
> >
> > > -----Original Message-----
> > > From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> > > Sent: Thursday, July 19, 2018 4:11 PM
> > > To: Gu, Jinxiang/顾 金香 <gujx@cn.fujitsu.com>
> > > Cc: linux-btrfs@vger.kernel.org
> > > Subject: [bug report] btrfs: Add type check when reading a chunk
> > >
> > > Hello Gu Jinxiang,
> > >
> > > The patch 72e75ed03c8d: "btrfs: Add type check when reading a chunk"
> > > from Jul 4, 2018, leads to the following static checker warning:
> > >
> > > fs/btrfs/volumes.c:6388 btrfs_check_chunk_valid()
> > > warn: AND to zero '0x4 & 0x1'
> > >
> > > fs/btrfs/volumes.c
> > > 6356 if (!is_power_of_2(stripe_len) || stripe_len != BTRFS_STRIPE_LEN) {
> > > 6357 btrfs_err(fs_info, "invalid chunk stripe length: %llu",
> > > 6358 stripe_len);
> > > 6359 return -EIO;
> > > 6360 }
> > > 6361 if (~(BTRFS_BLOCK_GROUP_TYPE_MASK | BTRFS_BLOCK_GROUP_PROFILE_MASK) &
> > > 6362 type) {
> > > 6363 btrfs_err(fs_info, "unrecognized chunk type: %llu",
> > > 6364 ~(BTRFS_BLOCK_GROUP_TYPE_MASK |
> > > 6365 BTRFS_BLOCK_GROUP_PROFILE_MASK) &
> > > 6366 btrfs_chunk_type(leaf, chunk));
> > > 6367 return -EIO;
> > > 6368 }
> > > 6369
> > > 6370 if ((type & BTRFS_BLOCK_GROUP_TYPE_MASK) == 0) {
> > > 6371 btrfs_err(fs_info, "missing chunk type flag: %llu", type);
> > > 6372 return -EIO;
> > > 6373 }
> > > 6374
> > > 6375 if ((type & BTRFS_BLOCK_GROUP_SYSTEM) &&
> > > 6376 (type & (BTRFS_BLOCK_GROUP_METADATA | BTRFS_BLOCK_GROUP_DATA))) {
> > > 6377 btrfs_err(fs_info,
> > > 6378 "system chunk with data or metadata type: %llu", type);
> > > 6379 return -EIO;
> > > 6380 }
> > > 6381
> > > 6382 features = btrfs_super_incompat_flags(fs_info->super_copy);
> > > 6383 if (features & BTRFS_FEATURE_INCOMPAT_MIXED_GROUPS)
> > > 6384 mixed = 1;
> > > 6385
> > > 6386 if (!mixed) {
> > > 6387 if (type &
> > > 6388 (BTRFS_BLOCK_GROUP_METADATA & BTRFS_BLOCK_GROUP_DATA)) {
> > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > Was this supposed to be | or perhaps check that both are set?
> > Yes. It should be |.
> > Thank you, I'll send a patch to fix it.
>
> Not needed, I'll fix the patch directly.
And that leads to failed mount:
[ 10.867868] BTRFS error (device vda): mixed chunk type in non-mixed mode: 1
[ 10.871084] BTRFS error (device vda): failed to read chunk tree: -5
[ 10.908541] BTRFS error (device vda): open_ctree failed
Please send fixed version.
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [bug report] btrfs: Add type check when reading a chunk
2018-07-19 10:14 ` David Sterba
@ 2018-07-20 5:32 ` Gu, Jinxiang
0 siblings, 0 replies; 5+ messages in thread
From: Gu, Jinxiang @ 2018-07-20 5:32 UTC (permalink / raw)
To: dsterba@suse.cz, Dan Carpenter, linux-btrfs@vger.kernel.org
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 3886 bytes --]
> -----Original Message-----
> From: David Sterba [mailto:dsterba@suse.cz]
> Sent: Thursday, July 19, 2018 6:14 PM
> To: dsterba@suse.cz; Gu, Jinxiang/顾 金香 <gujx@cn.fujitsu.com>; Dan Carpenter <dan.carpenter@oracle.com>;
> linux-btrfs@vger.kernel.org
> Subject: Re: [bug report] btrfs: Add type check when reading a chunk
>
> On Thu, Jul 19, 2018 at 11:22:01AM +0200, David Sterba wrote:
> > On Thu, Jul 19, 2018 at 08:18:25AM +0000, Gu, Jinxiang wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> > > > Sent: Thursday, July 19, 2018 4:11 PM
> > > > To: Gu, Jinxiang/顾 金香 <gujx@cn.fujitsu.com>
> > > > Cc: linux-btrfs@vger.kernel.org
> > > > Subject: [bug report] btrfs: Add type check when reading a chunk
> > > >
> > > > Hello Gu Jinxiang,
> > > >
> > > > The patch 72e75ed03c8d: "btrfs: Add type check when reading a chunk"
> > > > from Jul 4, 2018, leads to the following static checker warning:
> > > >
> > > > fs/btrfs/volumes.c:6388 btrfs_check_chunk_valid()
> > > > warn: AND to zero '0x4 & 0x1'
> > > >
> > > > fs/btrfs/volumes.c
> > > > 6356 if (!is_power_of_2(stripe_len) || stripe_len != BTRFS_STRIPE_LEN) {
> > > > 6357 btrfs_err(fs_info, "invalid chunk stripe length: %llu",
> > > > 6358 stripe_len);
> > > > 6359 return -EIO;
> > > > 6360 }
> > > > 6361 if (~(BTRFS_BLOCK_GROUP_TYPE_MASK | BTRFS_BLOCK_GROUP_PROFILE_MASK) &
> > > > 6362 type) {
> > > > 6363 btrfs_err(fs_info, "unrecognized chunk type: %llu",
> > > > 6364 ~(BTRFS_BLOCK_GROUP_TYPE_MASK |
> > > > 6365 BTRFS_BLOCK_GROUP_PROFILE_MASK) &
> > > > 6366 btrfs_chunk_type(leaf, chunk));
> > > > 6367 return -EIO;
> > > > 6368 }
> > > > 6369
> > > > 6370 if ((type & BTRFS_BLOCK_GROUP_TYPE_MASK) == 0) {
> > > > 6371 btrfs_err(fs_info, "missing chunk type flag: %llu", type);
> > > > 6372 return -EIO;
> > > > 6373 }
> > > > 6374
> > > > 6375 if ((type & BTRFS_BLOCK_GROUP_SYSTEM) &&
> > > > 6376 (type & (BTRFS_BLOCK_GROUP_METADATA | BTRFS_BLOCK_GROUP_DATA))) {
> > > > 6377 btrfs_err(fs_info,
> > > > 6378 "system chunk with data or metadata type: %llu", type);
> > > > 6379 return -EIO;
> > > > 6380 }
> > > > 6381
> > > > 6382 features = btrfs_super_incompat_flags(fs_info->super_copy);
> > > > 6383 if (features & BTRFS_FEATURE_INCOMPAT_MIXED_GROUPS)
> > > > 6384 mixed = 1;
> > > > 6385
> > > > 6386 if (!mixed) {
> > > > 6387 if (type &
> > > > 6388 (BTRFS_BLOCK_GROUP_METADATA & BTRFS_BLOCK_GROUP_DATA)) {
> > > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > > Was this supposed to be | or perhaps check that both are set?
> > > Yes. It should be |.
> > > Thank you, I'll send a patch to fix it.
> >
> > Not needed, I'll fix the patch directly.
>
> And that leads to failed mount:
>
> [ 10.867868] BTRFS error (device vda): mixed chunk type in non-mixed mode: 1
> [ 10.871084] BTRFS error (device vda): failed to read chunk tree: -5
> [ 10.908541] BTRFS error (device vda): open_ctree failed
>
> Please send fixed version.
I send a patch to fix this.
Patch: btrfs: fix bug of chunk type check
And, if possible, please just fold it into 72e75ed03c8d: "btrfs: Add type check when reading a chunk".
Thanks, Gu Jinxiang
>
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±ý»k~ÏâžØ^n‡r¡ö¦zË\x1aëh™¨èÚ&£ûàz¿äz¹Þ—ú+€Ê+zf£¢·hšˆ§~††Ûiÿÿïêÿ‘êçz_è®\x0fæj:+v‰¨þ)ߣøm
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-20 6:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-19 8:10 [bug report] btrfs: Add type check when reading a chunk Dan Carpenter
2018-07-19 8:18 ` Gu, Jinxiang
2018-07-19 9:22 ` David Sterba
2018-07-19 10:14 ` David Sterba
2018-07-20 5:32 ` Gu, Jinxiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox