From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] btrfs: Remove unused -EIO assignment in end_bio_extent_readpage
Date: Tue, 19 Mar 2019 13:52:29 +0100 [thread overview]
Message-ID: <20190319125228.GI3516@twin.jikos.cz> (raw)
In-Reply-To: <20190318154520.4086-2-nborisov@suse.com>
On Mon, Mar 18, 2019 at 05:45:18PM +0200, Nikolay Borisov wrote:
> In case we hit the error case for a metadata buffer in
> end_bio_extent_readpage then 'ret' won't really be checked before it's
> written again to. This means the -EIO in this case will never be
> checked, just remove it.
>
> Fixes-coverity-id: 1442513
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
next prev parent reply other threads:[~2019-03-19 12:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 15:45 [PATCH 0/3] Couple of coverity fixes Nikolay Borisov
2019-03-18 15:45 ` [PATCH 1/3] btrfs: Remove unused -EIO assignment in end_bio_extent_readpage Nikolay Borisov
2019-03-19 12:52 ` David Sterba [this message]
2019-03-18 15:45 ` [PATCH 2/3] btrfs: Fix bound checking in qgroup_trace_new_subtree_blocks Nikolay Borisov
2019-03-19 3:31 ` Qu Wenruo
2019-03-18 15:45 ` [PATCH 3/3] btrfs: Avoid possible qgroup_rsv_size overflow in btrfs_calculate_inode_block_rsv_size Nikolay Borisov
2019-03-19 4:46 ` Qu Wenruo
2019-03-19 6:48 ` Nikolay Borisov
2019-03-19 6:56 ` Qu Wenruo
2019-03-19 13:08 ` David Sterba
2019-03-19 13:09 ` [PATCH 0/3] Couple of coverity fixes David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319125228.GI3516@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox