From: fdmanana@kernel.org
To: fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org, Filipe Manana <fdmanana@suse.com>
Subject: [PATCH] btrfs/146: remove unnecessary scratch unmount to avoid test failure
Date: Wed, 12 Jun 2019 11:05:44 +0100 [thread overview]
Message-ID: <20190612100544.1890-1-fdmanana@kernel.org> (raw)
From: Filipe Manana <fdmanana@suse.com>
Right at the beginning of the test we are unmonting the scratch device,
however at this point the device was never mounted, so the unmount fails
with an error message like the following:
umount: /home/fdmanana/btrfs-tests/scratch_1: not mounted
Which is not expected by the golden output and therefore causes the test
to fail.
Since the device/mount point was not mounted yet in the test, and since
the test framework unmounts the scratch device after each test finishes,
just remove the call to _scratch_unmount.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
tests/btrfs/146 | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/btrfs/146 b/tests/btrfs/146
index 8ec3128b..18e2eec0 100755
--- a/tests/btrfs/146
+++ b/tests/btrfs/146
@@ -38,7 +38,6 @@ _require_test_program fsync-err
_require_test_program dmerror
# bring up dmerror device
-_scratch_unmount
_dmerror_init
# Replace first device with error-test device
--
2.11.0
reply other threads:[~2019-06-12 10:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612100544.1890-1-fdmanana@kernel.org \
--to=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox