From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH] btrfs: Allow more disks missing for RAID10
Date: Thu, 18 Jul 2019 14:27:49 +0800 [thread overview]
Message-ID: <20190718062749.11276-1-wqu@suse.com> (raw)
RAID10 can accept as much as half of its disks to be missing, as long as
each sub stripe still has a good mirror.
Thanks to the per-chunk degradable check, we can handle it pretty easily
now.
So Add this special check for RAID10, to allow user to be creative
(or crazy) using btrfs RAID10.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
fs/btrfs/volumes.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index f209127a8bc6..65b10d13fc2d 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -7088,6 +7088,42 @@ int btrfs_read_sys_array(struct btrfs_fs_info *fs_info)
return -EIO;
}
+static bool check_raid10_rw_degradable(struct btrfs_fs_info *fs_info,
+ struct extent_map *em)
+{
+ struct map_lookup *map = em->map_lookup;
+ int sub_stripes = map->sub_stripes;
+ int num_stripes = map->num_stripes;
+ int tolerance = 1;
+ int i, j;
+
+ ASSERT(sub_stripes == 2);
+ ASSERT(num_stripes % sub_stripes == 0);
+ /*
+ * Check substripes as a group, in each group we need to
+ * have at least one good mirror;
+ */
+ for (i = 0; i < num_stripes / sub_stripes; i ++) {
+ int missing = 0;
+ for (j = 0; j < sub_stripes; j++) {
+ struct btrfs_device *dev = map->stripes[i * 2 + j].dev;
+
+ if (!dev || !dev->bdev ||
+ test_bit(BTRFS_DEV_STATE_MISSING, &dev->dev_state) ||
+ dev->last_flush_error)
+ missing++;
+ }
+ if (missing > tolerance) {
+ btrfs_warn(fs_info,
+"chunk %llu stripes %d,%d missing %d devices, max tolerance is %d for writable mount",
+ em->start, i, i + sub_stripes - 1, missing,
+ tolerance);
+ return false;
+ }
+ }
+ return true;
+}
+
/*
* Check if all chunks in the fs are OK for read-write degraded mount
*
@@ -7119,6 +7155,14 @@ bool btrfs_check_rw_degradable(struct btrfs_fs_info *fs_info,
int i;
map = em->map_lookup;
+ if (map->type & BTRFS_BLOCK_GROUP_RAID10) {
+ ret = check_raid10_rw_degradable(fs_info, em);
+ if (!ret) {
+ free_extent_map(em);
+ goto out;
+ }
+ goto next;
+ }
max_tolerated =
btrfs_get_num_tolerated_disk_barrier_failures(
map->type);
@@ -7141,6 +7185,7 @@ bool btrfs_check_rw_degradable(struct btrfs_fs_info *fs_info,
ret = false;
goto out;
}
+next:
next_start = extent_map_end(em);
free_extent_map(em);
--
2.22.0
next reply other threads:[~2019-07-18 6:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 6:27 Qu Wenruo [this message]
2019-07-25 18:37 ` [PATCH] btrfs: Allow more disks missing for RAID10 David Sterba
2019-07-25 19:14 ` Austin S. Hemmelgarn
2019-07-25 23:41 ` Qu Wenruo
2019-07-26 10:39 ` David Sterba
2019-07-31 6:58 ` Qu Wenruo
2019-07-31 13:23 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718062749.11276-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox