From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Allow more disks missing for RAID10
Date: Fri, 26 Jul 2019 12:39:03 +0200 [thread overview]
Message-ID: <20190726103902.GZ2868@twin.jikos.cz> (raw)
In-Reply-To: <a835760e-be9d-cfd9-d8c3-c316f34ec20f@gmx.com>
On Fri, Jul 26, 2019 at 07:41:41AM +0800, Qu Wenruo wrote:
>
>
> On 2019/7/26 上午2:37, David Sterba wrote:
> > On Thu, Jul 18, 2019 at 02:27:49PM +0800, Qu Wenruo wrote:
> >> RAID10 can accept as much as half of its disks to be missing, as long as
> >> each sub stripe still has a good mirror.
> >
> > Can you please make a test case for that?
>
> Fstests one or btrfs-progs one?
For fstests.
> > I think the number of devices that can be lost can be higher than a half
> > in some extreme cases: one device has copies of all stripes, 2nd copy
> > can be scattered randomly on the other devices, but that's highly
> > unlikely to happen.
> >
> > On average it's same as raid1, but the more exact check can potentially
> > utilize the stripe layout.
> >
> That will be at extent level, to me it's an internal level violation,
> far from what we want to improve.
Ah I don't mean to go the extent level, as you implemented it is enough
and an improvement.
next prev parent reply other threads:[~2019-07-26 10:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 6:27 [PATCH] btrfs: Allow more disks missing for RAID10 Qu Wenruo
2019-07-25 18:37 ` David Sterba
2019-07-25 19:14 ` Austin S. Hemmelgarn
2019-07-25 23:41 ` Qu Wenruo
2019-07-26 10:39 ` David Sterba [this message]
2019-07-31 6:58 ` Qu Wenruo
2019-07-31 13:23 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726103902.GZ2868@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox