Re: [PATCH v3 3/4] Btrfs: Switch to use new generic UUID API

[Johannes Thumshirn <jthumshirn@suse.de>]

On Thu, Jul 18, 2019 at 08:38:42PM +0300, Andy Shevchenko wrote:
> On Thu, Jul 18, 2019 at 07:20:17PM +0200, Johannes Thumshirn wrote:
> > On Wed, Jul 17, 2019 at 02:36:32PM +0300, Andy Shevchenko wrote:
> > > There are new types and helpers that are supposed to be used in new code.
> > > 
> > > As a preparation to get rid of legacy types and API functions do
> > > the conversion here.
> > 
> > Why? What was broken in the old versions? What benefit do we have apart from
> > unneeded churn?
> 
> I think Christoph can explain this better than me.
> 
> By the way, if you look to the headers, there is no more "old" API, it's
> covered as alias to the new one.

AFAIU it's mostly the naming that causes problems here as a little endian UUID
doesn't really exits, is called GUID.

But please at least document this in a cover letter. Also what tests did you
make? I know most of these functions have their origin in XFS.

Thanks,
	Johannes
-- 
Johannes Thumshirn                            SUSE Labs Filesystems
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850