Re: [PATCH v3 3/4] Btrfs: Switch to use new generic UUID API

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Thu, Jul 18, 2019 at 07:44:00PM +0200, Johannes Thumshirn wrote:
> On Thu, Jul 18, 2019 at 08:38:42PM +0300, Andy Shevchenko wrote:
> > On Thu, Jul 18, 2019 at 07:20:17PM +0200, Johannes Thumshirn wrote:
> > > On Wed, Jul 17, 2019 at 02:36:32PM +0300, Andy Shevchenko wrote:
> > > > There are new types and helpers that are supposed to be used in new code.
> > > > 
> > > > As a preparation to get rid of legacy types and API functions do
> > > > the conversion here.
> > > 
> > > Why? What was broken in the old versions? What benefit do we have apart from
> > > unneeded churn?
> > 
> > I think Christoph can explain this better than me.
> > 
> > By the way, if you look to the headers, there is no more "old" API, it's
> > covered as alias to the new one.
> 
> AFAIU it's mostly the naming that causes problems here as a little endian UUID
> doesn't really exits, is called GUID.

Yes, that's the main point for now.

> But please at least document this in a cover letter. Also what tests did you
> make? I know most of these functions have their origin in XFS.

I did only compile test.

-- 
With Best Regards,
Andy Shevchenko