From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH 0/2] Fix btrfs check handling of missing file extents
Date: Thu, 30 Jan 2020 15:47:34 -0500 [thread overview]
Message-ID: <20200130204736.49224-1-josef@toxicpanda.com> (raw)
While adding an xfstest for the missing file extent problem I fixed with the
series
btrfs: fix hole corruption issue with !NO_HOLES
I was failing to fail my test without my patches, despite the file system being
actually wrong.
It turns out because the normal check mode sets its expected start to the first
file extent it finds, instead of 0. This means it misses any gaps between 0 and
the first file extent item in the inode.
The lowmem check does not have this issue, instead it doesn't take into account
the isize of the inode, so improperly fails when we have a gap but that is
outside of the isize. I fixed this as well.
With these patches we're able to properly find another set of corruptions, and
now my xfstest acts sanely. Thanks,
Josef
next reply other threads:[~2020-01-30 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 20:47 Josef Bacik [this message]
2020-01-30 20:47 ` [PATCH 1/2] btrfs-progs: fix check to catch gaps at the start of the file Josef Bacik
2020-03-05 15:38 ` David Sterba
2020-01-30 20:47 ` [PATCH 2/2] btrfs-progs: fix lowmem check's handling of holes Josef Bacik
2020-03-04 13:53 ` [PATCH 0/2] Fix btrfs check handling of missing file extents David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130204736.49224-1-josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox