From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 1/2] btrfs-progs: fix check to catch gaps at the start of the file
Date: Thu, 5 Mar 2020 16:38:19 +0100 [thread overview]
Message-ID: <20200305153819.GD2902@twin.jikos.cz> (raw)
In-Reply-To: <20200130204736.49224-2-josef@toxicpanda.com>
On Thu, Jan 30, 2020 at 03:47:35PM -0500, Josef Bacik wrote:
> When writing my test for the i_size patches, I noticed that I was not
> actually failing without my patches as I should have been. This is
> because we assume the first extent we find is the first valid spot, so
> we don't actually add a hole entry if there is no extent at offset 0.
> Fix this by setting our extent_start and extent_end to 0 so we can
> properly catch the corruption.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
This patch does not pass tests:
[TEST/fsck] 020-extent-ref-cases
failed: /labs/dsterba/gits/btrfs-progs/btrfs check ./keyed_data_ref_with_shared_leaf.img.restored
test failed for case 020-extent-ref-cases
next prev parent reply other threads:[~2020-03-05 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 20:47 [PATCH 0/2] Fix btrfs check handling of missing file extents Josef Bacik
2020-01-30 20:47 ` [PATCH 1/2] btrfs-progs: fix check to catch gaps at the start of the file Josef Bacik
2020-03-05 15:38 ` David Sterba [this message]
2020-01-30 20:47 ` [PATCH 2/2] btrfs-progs: fix lowmem check's handling of holes Josef Bacik
2020-03-04 13:53 ` [PATCH 0/2] Fix btrfs check handling of missing file extents David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305153819.GD2902@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox