From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 1/3] btrfs: add a comment describing block-rsvs
Date: Fri, 7 Feb 2020 16:11:37 +0100 [thread overview]
Message-ID: <20200207151137.GF2654@twin.jikos.cz> (raw)
In-Reply-To: <20200204181856.765916-2-josef@toxicpanda.com>
On Tue, Feb 04, 2020 at 01:18:54PM -0500, Josef Bacik wrote:
> This is a giant comment at the top of block-rsv.c describing generally
> how block rsvs work. It is purely about the block rsv's themselves, and
> nothing to do with how the actual reservation system works.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
> fs/btrfs/block-rsv.c | 91 ++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 91 insertions(+)
>
> diff --git a/fs/btrfs/block-rsv.c b/fs/btrfs/block-rsv.c
> index d07bd41a7c1e..c3843a0001cb 100644
> --- a/fs/btrfs/block-rsv.c
> +++ b/fs/btrfs/block-rsv.c
> @@ -6,6 +6,97 @@
> #include "space-info.h"
> #include "transaction.h"
>
> +/*
> + * HOW DO BLOCK RSVS WORK
For documentation please try to avoid abbreviations unless they're at
least somehow explained or can be infered from the previous.
RSVS = RESERVES
next prev parent reply other threads:[~2020-02-07 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 18:18 [PATCH 0/3][v2] Add comments describing how space reservation works Josef Bacik
2020-02-04 18:18 ` [PATCH 1/3] btrfs: add a comment describing block-rsvs Josef Bacik
2020-02-07 15:11 ` David Sterba [this message]
2020-02-04 18:18 ` [PATCH 2/3] btrfs: add a comment describing delalloc space reservation Josef Bacik
2020-02-04 18:18 ` [PATCH 3/3] btrfs: describe the space reservation system in general Josef Bacik
2020-02-05 13:32 ` [PATCH 0/3][v2] Add comments describing how space reservation works David Sterba
-- strict thread matches above, loose matches on Subject: below --
2020-02-03 20:44 [PATCH 0/3] " Josef Bacik
2020-02-03 20:44 ` [PATCH 1/3] btrfs: add a comment describing block-rsvs Josef Bacik
2020-02-04 9:30 ` Qu Wenruo
2020-02-04 10:32 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207151137.GF2654@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox