From: David Sterba <dsterba@suse.cz>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: David Sterba <dsterba@suse.cz>,
"linux-btrfs @ vger . kernel . org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 0/5] Fix memory leak on failed cache-writes
Date: Tue, 11 Feb 2020 18:59:03 +0100 [thread overview]
Message-ID: <20200211175903.GC2902@twin.jikos.cz> (raw)
In-Reply-To: <20200211151023.16060-1-johannes.thumshirn@wdc.com>
On Wed, Feb 12, 2020 at 12:10:18AM +0900, Johannes Thumshirn wrote:
> Fstests' test case generic/475 reliably leaks the btrfs_io_ctl::pages
> allocated in __btrfs_write_out_cache().
>
> The first four patches are small things I noticed while hunting down the
> problem and are independant of the last patch in this series freeing the pages
> when we throw away a dirty block group.
Thanks, just a note about the patch ordering: the fix 5/5 should go
first so it applies cleanly without the unrelated cleanups. As it's a
leak fix it'll go to some rc and then to stable.
next prev parent reply other threads:[~2020-02-11 18:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 15:10 [PATCH 0/5] Fix memory leak on failed cache-writes Johannes Thumshirn
2020-02-11 15:10 ` [PATCH 1/5] btrfs: use inode from io_ctl in io_ctl_prepare_pages Johannes Thumshirn
2020-02-11 15:10 ` [PATCH 2/5] btrfs: make the uptodate argument of io_ctl_add_pages() boolean Johannes Thumshirn
2020-02-11 15:10 ` [PATCH 3/5] btrfs: use standard debug config option to enable free-space-cache debug prints Johannes Thumshirn
2020-02-11 15:10 ` [PATCH 4/5] btrfs: simplify error handling in __btrfs_write_out_cache() Johannes Thumshirn
2020-02-11 15:10 ` [PATCH 5/5] btrfs: free allocated pages jon failed cache write-out Johannes Thumshirn
2020-02-11 17:59 ` David Sterba [this message]
2020-02-11 18:47 ` [PATCH 0/5] Fix memory leak on failed cache-writes Johannes Thumshirn
2020-02-13 20:10 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211175903.GC2902@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox