From: Josef Bacik <josef@toxicpanda.com>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>,
David Sterba <dsterba@suse.cz>
Cc: "linux-btrfs @ vger . kernel . org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 0/5] Fix memory leak on failed cache-writes
Date: Thu, 13 Feb 2020 15:10:53 -0500 [thread overview]
Message-ID: <3e87325d-ca05-d2ee-8eef-dbaa9c694c84@toxicpanda.com> (raw)
In-Reply-To: <20200211151023.16060-1-johannes.thumshirn@wdc.com>
On 2/11/20 10:10 AM, Johannes Thumshirn wrote:
> Fstests' test case generic/475 reliably leaks the btrfs_io_ctl::pages
> allocated in __btrfs_write_out_cache().
>
> The first four patches are small things I noticed while hunting down the
> problem and are independant of the last patch in this series freeing the pages
> when we throw away a dirty block group.
>
> Johannes Thumshirn (5):
> btrfs: use inode from io_ctl in io_ctl_prepare_pages
> btrfs: make the uptodate argument of io_ctl_add_pages() boolean.
> btrfs: use standard debug config option to enable free-space-cache
> debug prints
> btrfs: simplify error handling in __btrfs_write_out_cache()
> btrfs: free allocated pages jon failed cache write-out
>
> fs/btrfs/disk-io.c | 6 ++++++
> fs/btrfs/free-space-cache.c | 44 ++++++++++++++++++++++++--------------------
> fs/btrfs/free-space-cache.h | 1 +
> 3 files changed, 31 insertions(+), 20 deletions(-)
>
Weird, I swear I reviewed these yesterday, but I don't see any replies from me.
You can add
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
to the whole series. Thanks,
Josef
prev parent reply other threads:[~2020-02-13 20:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 15:10 [PATCH 0/5] Fix memory leak on failed cache-writes Johannes Thumshirn
2020-02-11 15:10 ` [PATCH 1/5] btrfs: use inode from io_ctl in io_ctl_prepare_pages Johannes Thumshirn
2020-02-11 15:10 ` [PATCH 2/5] btrfs: make the uptodate argument of io_ctl_add_pages() boolean Johannes Thumshirn
2020-02-11 15:10 ` [PATCH 3/5] btrfs: use standard debug config option to enable free-space-cache debug prints Johannes Thumshirn
2020-02-11 15:10 ` [PATCH 4/5] btrfs: simplify error handling in __btrfs_write_out_cache() Johannes Thumshirn
2020-02-11 15:10 ` [PATCH 5/5] btrfs: free allocated pages jon failed cache write-out Johannes Thumshirn
2020-02-11 17:59 ` [PATCH 0/5] Fix memory leak on failed cache-writes David Sterba
2020-02-11 18:47 ` Johannes Thumshirn
2020-02-13 20:10 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e87325d-ca05-d2ee-8eef-dbaa9c694c84@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=dsterba@suse.cz \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox