From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org, dsterba@suse.com
Subject: Re: [PATCH 0/4 RESEND 1-3/4 v5 4/4] btrfs, sysfs cleanup and add dev_state
Date: Tue, 11 Feb 2020 20:29:04 +0100 [thread overview]
Message-ID: <20200211192904.GG2902@twin.jikos.cz> (raw)
In-Reply-To: <5a9e45e2-645c-e15e-c87c-6914d3e2f397@oracle.com>
On Tue, Feb 11, 2020 at 12:46:58PM +0800, Anand Jain wrote:
> > I've tested current master and the device ids are indeed placed under
> > device/ and there is no devinfo/, so this needs to be fixed.
> >
> > Preparatory patches I was referring to are:
> >
> > bc036bb33524 btrfs: sysfs, merge btrfs_sysfs_add devices_kobj and fsid
> > be2cf92e0a2f btrfs: sysfs, rename btrfs_sysfs_add_device()
> > c6761a9ed329 btrfs: sysfs, btrfs_sysfs_add_fsid() drop unused argument parent
> > b5501504cb6a btrfs: sysfs, rename devices kobject holder to devices_kobj
> >
> > so I'll have another look at what you sent.
> >
> David,
>
> Busy? Can I ping on this?
>
> Those aren't the preparatory patches. The patches sent here applies
> nicely on misc-next with git revert 668e48af7a94
Do you realize that patch 668e48af7a94 had been merged to linus/master
at the time you sent the patchset a week ago? How can I do git revert?
That was in the middle of merge window, 2 weeks after code freeze. If I
don't merge a patch intentionally or by mistake, then you send me an
incremental change.
Please send update with this patch order:
* "btrfs: sysfs, add UUID/devinfo kobject"
* fixup of the device id files created under devices
* the other cleanups
next prev parent reply other threads:[~2020-02-11 19:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 11:00 [PATCH 0/4 RESEND 1-3/4 v5 4/4] btrfs, sysfs cleanup and add dev_state Anand Jain
2020-02-03 11:00 ` [PATCH resend 1/4] btrfs: sysfs, use btrfs_sysfs_remove_fsid in fail return in add_fsid Anand Jain
2020-02-03 11:00 ` [PATCH resend 2/4] btrfs: sysfs, add UUID/devinfo kobject Anand Jain
2020-02-03 11:00 ` [PATCH resend v2 3/4] btrfs: sysfs, rename device_link add,remove functions Anand Jain
2020-02-03 11:00 ` [PATCH v5 4/4] btrfs: sysfs, add devid/dev_state kobject and device attribute Anand Jain
2020-02-03 17:16 ` [PATCH 0/4 RESEND 1-3/4 v5 4/4] btrfs, sysfs cleanup and add dev_state David Sterba
2020-02-06 6:31 ` Anand Jain
2020-02-06 14:11 ` David Sterba
2020-02-11 4:46 ` Anand Jain
2020-02-11 19:29 ` David Sterba [this message]
2020-02-12 9:29 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211192904.GG2902@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox