Re: [PATCH 0/4 RESEND 1-3/4 v5 4/4] btrfs, sysfs cleanup and add dev_state

[Anand Jain <anand.jain@oracle.com>]

On 2/6/20 10:11 PM, David Sterba wrote:
> On Thu, Feb 06, 2020 at 02:31:02PM +0800, Anand Jain wrote:
>>
>>
>> On 2/4/20 1:16 AM, David Sterba wrote:
>>> On Mon, Feb 03, 2020 at 07:00:08PM +0800, Anand Jain wrote:
>>>> Resend:
>>>>     Patch 4/4 is already integrated without the cleanup and preparatory
>>>>     patches (1,2,3)/4. So I am resending those 3 patches. And the changes
>>>>     in patch 4/4 as in misc-next is imported into patch v5 4/4 here. Patch
>>>>     4/4 has the details of the changes.
>>>
>>> All the patches have been merged and now are in linus/master branch.
>>
>>
>> David,
>>
>>> I haven't reordered the patches so they're not in a group and the
>>> preparatory patches are about 10 commits above v5.5-rc7 which is the
>>> beginning of the branch.
>>
>>
>>    It will cause problem during bisect, without the preparatory patches
>>    the devid kobject lands under devices instead of under devinfo,
>>    that's how I noticed that preparatory patches are missing.
> 
> I've tested current master and the device ids are indeed placed under
> device/ and there is no devinfo/, so this needs to be fixed.
> 
> Preparatory patches I was referring to are:
> 
> bc036bb33524  btrfs: sysfs, merge btrfs_sysfs_add devices_kobj and fsid
> be2cf92e0a2f  btrfs: sysfs, rename btrfs_sysfs_add_device()
> c6761a9ed329  btrfs: sysfs, btrfs_sysfs_add_fsid() drop unused argument parent
> b5501504cb6a  btrfs: sysfs, rename devices kobject holder to devices_kobj
> 
> so I'll have another look at what you sent.
> 
David,

  Busy? Can I ping on this?

  Those aren't the preparatory patches. The patches sent here applies
  nicely on misc-next with git revert 668e48af7a94

Thanks, Anand