* [PATCH 01/30] btrfs: Add missing annotation for release_extent_buffer() [not found] ` <20200223231711.157699-1-jbi.octave@gmail.com> @ 2020-02-23 23:16 ` Jules Irenge 2020-02-23 23:27 ` Nikolay Borisov 2020-02-24 15:19 ` David Sterba 0 siblings, 2 replies; 3+ messages in thread From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw) To: boqun.feng Cc: jbi.octave, linux-kernel, Chris Mason, Josef Bacik, David Sterba, open list:BTRFS FILE SYSTEM Sparse reports a warning at release_extent_buffer() warning: context imbalance in release_extent_buffer() - unexpected unlock The root cause is the missing annotation at release_extent_buffer() Add the missing __releases(&eb->refs_lock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- fs/btrfs/extent_io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index c0f202741e09..8b6d6893e7a7 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -5230,6 +5230,7 @@ static inline void btrfs_release_extent_buffer_rcu(struct rcu_head *head) } static int release_extent_buffer(struct extent_buffer *eb) + __releases(&eb->refs_lock) { lockdep_assert_held(&eb->refs_lock); -- 2.24.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 01/30] btrfs: Add missing annotation for release_extent_buffer() 2020-02-23 23:16 ` [PATCH 01/30] btrfs: Add missing annotation for release_extent_buffer() Jules Irenge @ 2020-02-23 23:27 ` Nikolay Borisov 2020-02-24 15:19 ` David Sterba 1 sibling, 0 replies; 3+ messages in thread From: Nikolay Borisov @ 2020-02-23 23:27 UTC (permalink / raw) To: Jules Irenge, boqun.feng Cc: linux-kernel, Chris Mason, Josef Bacik, David Sterba, open list:BTRFS FILE SYSTEM On 24.02.20 г. 1:16 ч., Jules Irenge wrote: > Sparse reports a warning at release_extent_buffer() > warning: context imbalance in release_extent_buffer() - unexpected unlock > > The root cause is the missing annotation at release_extent_buffer() > Add the missing __releases(&eb->refs_lock) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Reviewed-by: Nikolay Borisov <nborisov@suse.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 01/30] btrfs: Add missing annotation for release_extent_buffer() 2020-02-23 23:16 ` [PATCH 01/30] btrfs: Add missing annotation for release_extent_buffer() Jules Irenge 2020-02-23 23:27 ` Nikolay Borisov @ 2020-02-24 15:19 ` David Sterba 1 sibling, 0 replies; 3+ messages in thread From: David Sterba @ 2020-02-24 15:19 UTC (permalink / raw) To: Jules Irenge Cc: boqun.feng, linux-kernel, Chris Mason, Josef Bacik, David Sterba, open list:BTRFS FILE SYSTEM On Sun, Feb 23, 2020 at 11:16:42PM +0000, Jules Irenge wrote: > Sparse reports a warning at release_extent_buffer() > warning: context imbalance in release_extent_buffer() - unexpected unlock > > The root cause is the missing annotation at release_extent_buffer() > Add the missing __releases(&eb->refs_lock) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Added to misc-next, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-24 15:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <0/30>
[not found] ` <20200223231711.157699-1-jbi.octave@gmail.com>
2020-02-23 23:16 ` [PATCH 01/30] btrfs: Add missing annotation for release_extent_buffer() Jules Irenge
2020-02-23 23:27 ` Nikolay Borisov
2020-02-24 15:19 ` David Sterba
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox