From: David Sterba <dsterba@suse.cz>
To: Roman Gushchin <guro@fb.com>
Cc: Josef Bacik <josef@toxicpanda.com>, Chris Mason <clm@fb.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, Rik van Riel <riel@surriel.com>
Subject: Re: [PATCH v3] btrfs: implement migratepage callback
Date: Wed, 11 Mar 2020 01:40:12 +0100 [thread overview]
Message-ID: <20200311004012.GC12659@twin.jikos.cz> (raw)
In-Reply-To: <20200305005735.583008-1-guro@fb.com>
On Wed, Mar 04, 2020 at 04:57:35PM -0800, Roman Gushchin wrote:
> Currently btrfs doesn't provide a migratepage callback. It means that
> fallback_migrate_page() is used to migrate btrfs pages.
The callback exists for the metadata pages (btree_migratepage), so I've
added 'for data pages' where appropriate.
> fallback_migrate_page() cannot move dirty pages, instead it tries to
> flush them (in sync mode) or just fails (in async mode).
>
> In the sync mode pages which are scheduled to be processed by
> btrfs_writepage_fixup_worker() can't be effectively flushed by the
> migration code, because there is no established way to wait for the
> completion of the delayed work.
>
> It all leads to page migration failures.
>
> To fix it the patch implements a btrs-specific migratepage callback,
> which is similar to iomap_migrate_page() used by some other fs, except
> it does take care of the PagePrivate2 flag which is used for data
> ordering purposes.
>
> v3: fixed the build issue once again
> v2: fixed the build issue found by the kbuild test robot <lkp@intel.com>
>
> Signed-off-by: Roman Gushchin <guro@fb.com>
> Reviewed-by: Chris Mason <clm@fb.com>
Added to devel queue, thanks.
next prev parent reply other threads:[~2020-03-11 0:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 0:57 [PATCH v3] btrfs: implement migratepage callback Roman Gushchin
2020-03-11 0:40 ` David Sterba [this message]
2020-03-11 1:30 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311004012.GC12659@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=guro@fb.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox