From: David Sterba <dsterba@suse.cz>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>, osandov@fb.com
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] btrfs: inode: Fix uninitialized variable bug
Date: Wed, 1 Apr 2020 18:00:50 +0200 [thread overview]
Message-ID: <20200401160050.GV5920@twin.jikos.cz> (raw)
In-Reply-To: <20200327200135.GA3472@embeddedor>
On Fri, Mar 27, 2020 at 03:01:35PM -0500, Gustavo A. R. Silva wrote:
> geom.len is being used without being properly initialized, previously.
>
> Fix this by placing ASSERT(geom.len <= INT_MAX); after geom.len has been
> initialized.
>
> Addresses-Coverity-ID: 1491912 ("Uninitialized scalar variable")
> Fixes: 1eb52c8bd8d6 ("btrfs: get rid of one layer of bios in direct I/O")
Thanks. This is in a development branch so the fixup can be folded in,
we're expecting more revisions of the patchset anyway. CCing Omar.
prev parent reply other threads:[~2020-04-01 16:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 20:01 [PATCH][next] btrfs: inode: Fix uninitialized variable bug Gustavo A. R. Silva
2020-04-01 16:00 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401160050.GV5920@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=gustavo@embeddedor.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox