From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: Marcos Paulo de Souza <marcos@mpdesouza.com>,
dsterba@suse.com, linux-btrfs@vger.kernel.org,
Marcos Paulo de Souza <mpdesouza@suse.com>
Subject: Re: [PATCH] btrfs: ctree: Add do {} while (0) in btrfs_{set|clear}_and_info
Date: Tue, 7 Jul 2020 16:10:18 +0200 [thread overview]
Message-ID: <20200707141018.GJ27795@twin.jikos.cz> (raw)
In-Reply-To: <14b394fd-b338-63c9-a8a3-ba3c725f1e79@suse.com>
On Tue, Jul 07, 2020 at 11:34:12AM +0300, Nikolay Borisov wrote:
>
>
> On 6.07.20 г. 17:59 ч., Marcos Paulo de Souza wrote:
> > From: Marcos Paulo de Souza <mpdesouza@suse.com>
> >
> > Without this change it's not possible to use these macros and having an
> > if-else construction without using braces.
> >
> > Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
>
> This change would have been better accompanied with another one showing
> intended usage. If it's part of a bigger rework then postpone it and
> send everything altogether.
I think the change is good as is, multi-statement macros should always be
enclosed in do {} while(0);
next prev parent reply other threads:[~2020-07-07 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 14:59 [PATCH] btrfs: ctree: Add do {} while (0) in btrfs_{set|clear}_and_info Marcos Paulo de Souza
2020-07-07 8:34 ` Nikolay Borisov
2020-07-07 13:38 ` Marcos Paulo de Souza
2020-07-07 14:10 ` David Sterba [this message]
2020-07-07 14:23 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707141018.GJ27795@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=marcos@mpdesouza.com \
--cc=mpdesouza@suse.com \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox