From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 00/23][v4] Change data reservations to use the ticketing infra
Date: Thu, 13 Aug 2020 17:10:24 +0200 [thread overview]
Message-ID: <20200813151024.GL2026@twin.jikos.cz> (raw)
In-Reply-To: <121b9dab-888b-4be3-30bf-5719b9017014@suse.com>
On Wed, Jul 22, 2020 at 11:35:15AM +0300, Nikolay Borisov wrote:
>
>
> On 21.07.20 г. 17:22 ч., Josef Bacik wrote:
> > v3->v4:
> > - Rebased onto a recent misc-next, slight fixup because of commenting around the
> > flush states.
> >
> > v2->v3:
> > - Rebased onto a recent misc-next
> >
> > v1->v2:
> > - Adjusted a comment in may_commit_transaction.
> > - Fixed one of the intermediate patches to properly update ->reclaim_size.
> >
> > We've had two different things in place to reserve data and metadata space,
> > because generally speaking data is much simpler. However the data reservations
> > still suffered from the same issues that plagued metadata reservations, you
> > could get multiple tasks racing in to get reservations. This causes problems
> > with cases like write/delete loops where we should be able to fill up the fs,
> > delete everything, and go again. You would sometimes race with a flusher that's
> > trying to unpin the free space, take it's reservations, and then it would fail.
> >
> > Fix this by moving the data reservations under the metadata ticketing
> > infrastructure. This gets rid of that problem, and simplifies our enospc code
> > more by consolidating it into a single path. Thanks,
> >
> > Josef
> >
>
> I've gone through the series again and it looks good. However,
> btrfs_alloc_data_chunk_ondemand no longer allocates a data chunk but
> simply tries to reserve the requested data space. This means this series
> needs another patch giving it a more becoming name, something like
> btrfs_(alloc|reserve)_data_space or some such ?
Yes please, this could be confunsing as allocation and reservation are
different things.
next prev parent reply other threads:[~2020-08-13 15:11 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 14:22 [PATCH 00/23][v4] Change data reservations to use the ticketing infra Josef Bacik
2020-07-21 14:22 ` [PATCH 01/23] btrfs: change nr to u64 in btrfs_start_delalloc_roots Josef Bacik
2020-07-21 14:22 ` [PATCH 02/23] btrfs: remove orig from shrink_delalloc Josef Bacik
2020-07-21 14:22 ` [PATCH 03/23] btrfs: handle U64_MAX for shrink_delalloc Josef Bacik
2020-07-21 14:22 ` [PATCH 04/23] btrfs: make shrink_delalloc take space_info as an arg Josef Bacik
2020-07-21 14:22 ` [PATCH 05/23] btrfs: make ALLOC_CHUNK use the space info flags Josef Bacik
2020-07-21 14:22 ` [PATCH 06/23] btrfs: call btrfs_try_granting_tickets when freeing reserved bytes Josef Bacik
2020-07-21 14:22 ` [PATCH 07/23] btrfs: call btrfs_try_granting_tickets when unpinning anything Josef Bacik
2020-07-21 14:22 ` [PATCH 08/23] btrfs: call btrfs_try_granting_tickets when reserving space Josef Bacik
2020-07-21 14:22 ` [PATCH 09/23] btrfs: use the btrfs_space_info_free_bytes_may_use helper for delalloc Josef Bacik
2020-07-21 14:22 ` [PATCH 10/23] btrfs: use btrfs_start_delalloc_roots in shrink_delalloc Josef Bacik
2020-07-21 14:22 ` [PATCH 11/23] btrfs: check tickets after waiting on ordered extents Josef Bacik
2020-07-21 14:22 ` [PATCH 12/23] btrfs: add flushing states for handling data reservations Josef Bacik
2020-08-13 16:27 ` David Sterba
2020-07-21 14:22 ` [PATCH 13/23] btrfs: add the data transaction commit logic into may_commit_transaction Josef Bacik
2020-08-13 16:35 ` David Sterba
2020-07-21 14:22 ` [PATCH 14/23] btrfs: add btrfs_reserve_data_bytes and use it Josef Bacik
2020-07-21 14:22 ` [PATCH 15/23] btrfs: use ticketing for data space reservations Josef Bacik
2020-08-13 16:50 ` David Sterba
2020-08-13 16:51 ` David Sterba
2020-08-13 17:12 ` David Sterba
2020-07-21 14:22 ` [PATCH 16/23] btrfs: serialize data reservations if we are flushing Josef Bacik
2020-07-21 14:22 ` [PATCH 17/23] btrfs: use the same helper for data and metadata reservations Josef Bacik
2020-07-21 14:22 ` [PATCH 18/23] btrfs: drop the commit_cycles stuff for data reservations Josef Bacik
2020-07-21 14:22 ` [PATCH 19/23] btrfs: don't force commit if we are data Josef Bacik
2020-07-21 14:22 ` [PATCH 20/23] btrfs: run delayed iputs before committing the transaction for data Josef Bacik
2020-07-21 14:22 ` [PATCH 21/23] btrfs: flush delayed refs when trying to reserve data space Josef Bacik
2020-07-21 14:22 ` [PATCH 22/23] btrfs: do async reclaim for data reservations Josef Bacik
2020-07-21 14:22 ` [PATCH 23/23] btrfs: add a comment explaining the data flush steps Josef Bacik
2020-07-22 8:35 ` [PATCH 00/23][v4] Change data reservations to use the ticketing infra Nikolay Borisov
2020-08-13 15:10 ` David Sterba [this message]
2020-08-13 15:14 ` David Sterba
2020-08-17 10:42 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813151024.GL2026@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox