From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com,
Nikolay Borisov <nborisov@suse.com>
Subject: Re: [PATCH 12/23] btrfs: add flushing states for handling data reservations
Date: Thu, 13 Aug 2020 18:27:14 +0200 [thread overview]
Message-ID: <20200813162714.GN2026@twin.jikos.cz> (raw)
In-Reply-To: <20200721142234.2680-13-josef@toxicpanda.com>
On Tue, Jul 21, 2020 at 10:22:23AM -0400, Josef Bacik wrote:
> Currently the way we do data reservations is by seeing if we have enough
> space in our space_info. If we do not and we're a normal inode we'll
>
> 1) Attempt to force a chunk allocation until we can't anymore.
> 2) If that fails we'll flush delalloc, then commit the transaction, then
> run the delayed iputs.
>
> If we are a free space inode we're only allowed to force a chunk
> allocation. In order to use the normal flushing mechanism we need to
> encode this into a flush state array for normal inodes. Since both will
> start with allocating chunks until the space info is full there is no
> need to add this as a flush state, this will be handled specially.
>
> Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> Tested-by: Nikolay Borisov <nborisov@suse.com>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
> fs/btrfs/ctree.h | 2 ++
> fs/btrfs/space-info.c | 6 ++++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
> index 4e882ae15eea..a181f4959a1d 100644
> --- a/fs/btrfs/ctree.h
> +++ b/fs/btrfs/ctree.h
> @@ -2592,6 +2592,8 @@ enum btrfs_reserve_flush_enum {
> *
> * Can be interruped by fatal signal.
> */
> + BTRFS_RESERVE_FLUSH_DATA,
> + BTRFS_RESERVE_FLUSH_FREE_SPACE_INODE,
The new states are inserted between a comment that is there for the
FLUSH_ALL state. I'm not sure it's still valid or needs separate
comments and can't tell from looking at other patches in the series.
> BTRFS_RESERVE_FLUSH_ALL,
next prev parent reply other threads:[~2020-08-13 16:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 14:22 [PATCH 00/23][v4] Change data reservations to use the ticketing infra Josef Bacik
2020-07-21 14:22 ` [PATCH 01/23] btrfs: change nr to u64 in btrfs_start_delalloc_roots Josef Bacik
2020-07-21 14:22 ` [PATCH 02/23] btrfs: remove orig from shrink_delalloc Josef Bacik
2020-07-21 14:22 ` [PATCH 03/23] btrfs: handle U64_MAX for shrink_delalloc Josef Bacik
2020-07-21 14:22 ` [PATCH 04/23] btrfs: make shrink_delalloc take space_info as an arg Josef Bacik
2020-07-21 14:22 ` [PATCH 05/23] btrfs: make ALLOC_CHUNK use the space info flags Josef Bacik
2020-07-21 14:22 ` [PATCH 06/23] btrfs: call btrfs_try_granting_tickets when freeing reserved bytes Josef Bacik
2020-07-21 14:22 ` [PATCH 07/23] btrfs: call btrfs_try_granting_tickets when unpinning anything Josef Bacik
2020-07-21 14:22 ` [PATCH 08/23] btrfs: call btrfs_try_granting_tickets when reserving space Josef Bacik
2020-07-21 14:22 ` [PATCH 09/23] btrfs: use the btrfs_space_info_free_bytes_may_use helper for delalloc Josef Bacik
2020-07-21 14:22 ` [PATCH 10/23] btrfs: use btrfs_start_delalloc_roots in shrink_delalloc Josef Bacik
2020-07-21 14:22 ` [PATCH 11/23] btrfs: check tickets after waiting on ordered extents Josef Bacik
2020-07-21 14:22 ` [PATCH 12/23] btrfs: add flushing states for handling data reservations Josef Bacik
2020-08-13 16:27 ` David Sterba [this message]
2020-07-21 14:22 ` [PATCH 13/23] btrfs: add the data transaction commit logic into may_commit_transaction Josef Bacik
2020-08-13 16:35 ` David Sterba
2020-07-21 14:22 ` [PATCH 14/23] btrfs: add btrfs_reserve_data_bytes and use it Josef Bacik
2020-07-21 14:22 ` [PATCH 15/23] btrfs: use ticketing for data space reservations Josef Bacik
2020-08-13 16:50 ` David Sterba
2020-08-13 16:51 ` David Sterba
2020-08-13 17:12 ` David Sterba
2020-07-21 14:22 ` [PATCH 16/23] btrfs: serialize data reservations if we are flushing Josef Bacik
2020-07-21 14:22 ` [PATCH 17/23] btrfs: use the same helper for data and metadata reservations Josef Bacik
2020-07-21 14:22 ` [PATCH 18/23] btrfs: drop the commit_cycles stuff for data reservations Josef Bacik
2020-07-21 14:22 ` [PATCH 19/23] btrfs: don't force commit if we are data Josef Bacik
2020-07-21 14:22 ` [PATCH 20/23] btrfs: run delayed iputs before committing the transaction for data Josef Bacik
2020-07-21 14:22 ` [PATCH 21/23] btrfs: flush delayed refs when trying to reserve data space Josef Bacik
2020-07-21 14:22 ` [PATCH 22/23] btrfs: do async reclaim for data reservations Josef Bacik
2020-07-21 14:22 ` [PATCH 23/23] btrfs: add a comment explaining the data flush steps Josef Bacik
2020-07-22 8:35 ` [PATCH 00/23][v4] Change data reservations to use the ticketing infra Nikolay Borisov
2020-08-13 15:10 ` David Sterba
2020-08-13 15:14 ` David Sterba
2020-08-17 10:42 ` David Sterba
-- strict thread matches above, loose matches on Subject: below --
2020-07-08 13:59 [PATCH 00/23][v3] " Josef Bacik
2020-07-08 14:00 ` [PATCH 12/23] btrfs: add flushing states for handling data reservations Josef Bacik
2020-07-07 15:42 [PATCH 00/23][v2] Change data reservations to use the ticketing infra Josef Bacik
2020-07-07 15:42 ` [PATCH 12/23] btrfs: add flushing states for handling data reservations Josef Bacik
2020-06-30 13:58 [PATCH 00/23] Change data reservations to use the ticketing infra Josef Bacik
2020-06-30 13:59 ` [PATCH 12/23] btrfs: add flushing states for handling data reservations Josef Bacik
2020-02-04 16:19 [PATCH 0/23][v4] Convert data reservations to the ticketing infrastructure Josef Bacik
2020-02-04 16:19 ` [PATCH 12/23] btrfs: add flushing states for handling data reservations Josef Bacik
2020-02-04 16:54 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813162714.GN2026@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox