From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/4] Small QOI fixes for transaction_kthread
Date: Fri, 16 Oct 2020 16:26:31 +0200 [thread overview]
Message-ID: <20201016142631.GT6756@twin.jikos.cz> (raw)
In-Reply-To: <20201008122430.93433-1-nborisov@suse.com>
On Thu, Oct 08, 2020 at 03:24:26PM +0300, Nikolay Borisov wrote:
> Following 4 patches make transaction_kthread code slitghly more user friendly.
> Namely, patch 1 convert from open-coded multiplicaiton by HZ to using
> msecs_to_jiffies helper. Patch 2 relies on the observation that the running
> transaction is obtained under trans_lock so an extra check can be removed.
> Patch 3/4 could possibly be squashed into 1 but the net effect is that the code
> is more intuitive when sleeping in case a lower interval than commit_trans has
> elapsed.
>
>
> This has survived full xfstest run.
>
> Nikolay Borisov (4):
> btrfs: Use helpers to convert from seconds to jiffies in
> transaction_kthread
> btrfs: Remove redundant check
> btrfs: Record delta directly in transaction_kthread
1-3 added to misc-next, with some fixups.
> btrfs: Be smarter when sleeping in transaction_kthread
There's a comment regarding correctness.
prev parent reply other threads:[~2020-10-16 14:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 12:24 [PATCH 0/4] Small QOI fixes for transaction_kthread Nikolay Borisov
2020-10-08 12:24 ` [PATCH 1/4] btrfs: Use helpers to convert from seconds to jiffies in transaction_kthread Nikolay Borisov
2020-10-21 14:51 ` Josef Bacik
2020-10-21 15:03 ` Nikolay Borisov
2020-10-23 17:06 ` David Sterba
2020-10-08 12:24 ` [PATCH 2/4] btrfs: Remove redundant check Nikolay Borisov
2020-10-08 12:24 ` [PATCH 3/4] btrfs: Record delta directly in transaction_kthread Nikolay Borisov
2020-10-08 12:24 ` [PATCH 4/4] btrfs: Be smarter when sleeping " Nikolay Borisov
2020-10-16 14:20 ` David Sterba
2020-10-16 16:26 ` Nikolay Borisov
2020-10-19 7:21 ` Nikolay Borisov
2020-10-20 9:44 ` [PATCH v2] " Nikolay Borisov
2020-10-16 14:26 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016142631.GT6756@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox