Re: [PATCH 1/4] btrfs: Use helpers to convert from seconds to jiffies in transaction_kthread

[Nikolay Borisov <nborisov@suse.com>]

On 21.10.20 г. 17:51 ч., Josef Bacik wrote:
> On 10/8/20 8:24 AM, Nikolay Borisov wrote:
>> The kernel provides easy to understand helpers to convert from human
>> understandable units to the kernel-friendly 'jiffies'. So let's use
>> those to make the code easier to understand. No functional changes.
>>
>> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
>> ---
>>   fs/btrfs/disk-io.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
>> index 764001609a15..77b52b724733 100644
>> --- a/fs/btrfs/disk-io.c
>> +++ b/fs/btrfs/disk-io.c
>> @@ -1721,7 +1721,7 @@ static int transaction_kthread(void *arg)
>>         do {
>>           cannot_commit = false;
>> -        delay = HZ * fs_info->commit_interval;
>> +        delay = msecs_to_jiffies(fs_info->commit_interval * 1000);
> 
> Since we're now doing everything in msecs, why don't we just make sure
> ->commit_interval is set to msecs, that way we don't have to carry
> around the * 1000?  If we still need the multiplication we should be
> using MSEC_PER_SEC.  Thanks,

Yes, as a matter of fact I intend on making commit_interval into
jiffies, to completely eliminate the msecs_to_jiffies helpers here.

But that will be a follow on work once David merges the v2 of "Be
smarter" patch.

> 
> Josef
>