From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 13/14] lib/zstd: Convert constants to defines
Date: Thu, 21 Jan 2021 16:54:18 +0100 [thread overview]
Message-ID: <20210121155418.GA6430@twin.jikos.cz> (raw)
In-Reply-To: <20210120102526.310486-14-nborisov@suse.com>
On Wed, Jan 20, 2021 at 12:25:25PM +0200, Nikolay Borisov wrote:
> Those constants are really used internally by zstd and including
> linux/zstd.h into users results in the following warnings:
>
> In file included from fs/btrfs/zstd.c:19:
> ./include/linux/zstd.h:798:21: warning: ‘ZSTD_skippableHeaderSize’ defined but not used [-Wunused-const-variable=]
> 798 | static const size_t ZSTD_skippableHeaderSize = 8;
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> ./include/linux/zstd.h:796:21: warning: ‘ZSTD_frameHeaderSize_max’ defined but not used [-Wunused-const-variable=]
> 796 | static const size_t ZSTD_frameHeaderSize_max = ZSTD_FRAMEHEADERSIZE_MAX;
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> ./include/linux/zstd.h:795:21: warning: ‘ZSTD_frameHeaderSize_min’ defined but not used [-Wunused-const-variable=]
> 795 | static const size_t ZSTD_frameHeaderSize_min = ZSTD_FRAMEHEADERSIZE_MIN;
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> ./include/linux/zstd.h:794:21: warning: ‘ZSTD_frameHeaderSize_prefix’ defined but not used [-Wunused-const-variable=]
> 794 | static const size_t ZSTD_frameHeaderSize_prefix = 5;
>
> So fix those warnings by turning the constants into defines.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
> include/linux/zstd.h | 8 ++++----
That's not our file and you haven't CCed the maintainer, we can't modify
that code without an ack.
next prev parent reply other threads:[~2021-01-21 16:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 10:25 [PATCH v2 00/14] Make btrfs W=1 clean Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 01/14] btrfs: Document modified paramater of add_extent_mapping Nikolay Borisov
2021-01-20 15:54 ` Josef Bacik
2021-01-20 10:25 ` [PATCH v2 02/14] btrfs: Fix parameter description of btrfs_add_extent_mapping Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 03/14] btrfs: Fix function description format Nikolay Borisov
2021-01-21 16:23 ` David Sterba
2021-01-20 10:25 ` [PATCH v2 04/14] btrfs: Fix parameter description in delayed-ref.c functions Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 05/14] btrfs: Improve parameter description for __btrfs_write_out_cache Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 06/14] btrfs: Document now parameter of peek_discard_list Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 07/14] btrfs: Document fs_info in btrfs_rmap_block Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 08/14] btrfs: Fix description format of fs_info parameter of btrfs_wait_on_delayed_iputs Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 09/14] btrfs: Document btrfs_check_shared parameters Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 10/14] btrfs: Fix parameter description of btrfs_inode_rsv_release/btrfs_delalloc_release_space Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 11/14] btrfs: Fix parameter description in space-info.c Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 12/14] btrfs: Fix parameter description for functions in extent_io.c Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 13/14] lib/zstd: Convert constants to defines Nikolay Borisov
2021-01-21 15:54 ` David Sterba [this message]
2021-01-20 10:25 ` [PATCH v2 14/14] btrfs: Enable W=1 checks for btrfs Nikolay Borisov
2021-01-20 15:55 ` Josef Bacik
2021-01-21 7:31 ` Nikolay Borisov
2021-01-24 13:23 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121155418.GA6430@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox