From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: Josef Bacik <josef@toxicpanda.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 14/14] btrfs: Enable W=1 checks for btrfs
Date: Sun, 24 Jan 2021 14:23:20 +0100 [thread overview]
Message-ID: <20210124132320.GI1993@twin.jikos.cz> (raw)
In-Reply-To: <16775909-3cb6-ab13-5416-6f55546b0349@suse.com>
On Thu, Jan 21, 2021 at 09:31:34AM +0200, Nikolay Borisov wrote:
> On 20.01.21 г. 17:55 ч., Josef Bacik wrote:
> > On 1/20/21 5:25 AM, Nikolay Borisov wrote:
> >> Now that the btrfs' codebase is clean of W=1 warning let's enable those
> >> checks unconditionally for the entire fs/btrfs/ and its subdirectories.
> >>
> >> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> >
> > Once this is enabled I get
> >
> > fs/btrfs/zoned.c: In function ‘btrfs_sb_log_location_bdev’:
> > fs/btrfs/zoned.c:491:6: warning: variable ‘zone_size’ set but not used
> > [-Wunused-but-set-variable]
> > 491 | u64 zone_size;
> > | ^~~~~~~~~
> >
> > on misc-next. Thanks,
> >
>
> I know, I intentionally haven't fixed it since:
>
> a) David might be intending to merge other patches which will utilize
> this member
That's one possibility, but would show the warning until the zoned
patches get merged. I'd rather have a clean build once the W=1 build is
on.
I can insert a patch removing the variable, the zoned patches get still
rebased so that's fixable. Let me know if you want to send the patch as
it's from your series, or I can do that too.
> b) It shows a genuine problem that this patchset has uncovered ( I even
> mentioned this in the initial cover letter)
This should have been mentioned in the v2+ cover letter as well, along
with the version-to-version changelog.
prev parent reply other threads:[~2021-01-24 13:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 10:25 [PATCH v2 00/14] Make btrfs W=1 clean Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 01/14] btrfs: Document modified paramater of add_extent_mapping Nikolay Borisov
2021-01-20 15:54 ` Josef Bacik
2021-01-20 10:25 ` [PATCH v2 02/14] btrfs: Fix parameter description of btrfs_add_extent_mapping Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 03/14] btrfs: Fix function description format Nikolay Borisov
2021-01-21 16:23 ` David Sterba
2021-01-20 10:25 ` [PATCH v2 04/14] btrfs: Fix parameter description in delayed-ref.c functions Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 05/14] btrfs: Improve parameter description for __btrfs_write_out_cache Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 06/14] btrfs: Document now parameter of peek_discard_list Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 07/14] btrfs: Document fs_info in btrfs_rmap_block Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 08/14] btrfs: Fix description format of fs_info parameter of btrfs_wait_on_delayed_iputs Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 09/14] btrfs: Document btrfs_check_shared parameters Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 10/14] btrfs: Fix parameter description of btrfs_inode_rsv_release/btrfs_delalloc_release_space Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 11/14] btrfs: Fix parameter description in space-info.c Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 12/14] btrfs: Fix parameter description for functions in extent_io.c Nikolay Borisov
2021-01-20 10:25 ` [PATCH v2 13/14] lib/zstd: Convert constants to defines Nikolay Borisov
2021-01-21 15:54 ` David Sterba
2021-01-20 10:25 ` [PATCH v2 14/14] btrfs: Enable W=1 checks for btrfs Nikolay Borisov
2021-01-20 15:55 ` Josef Bacik
2021-01-21 7:31 ` Nikolay Borisov
2021-01-24 13:23 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210124132320.GI1993@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox