* [PATCH] btrfs: ordered-extent: fix comment for btrfs ordered extent flag bits
@ 2021-02-11 8:14 Qu Wenruo
2021-02-16 14:34 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Qu Wenruo @ 2021-02-11 8:14 UTC (permalink / raw)
To: linux-btrfs
There is small error in comment about BTRFS_ORDERED_* flags.
The 4 types are for ordered extent itself, not for direct io.
Only 3 types support direct io, REGULAR/NOCOW/PREALLOC.
Fix the comment to reflect that.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
fs/btrfs/ordered-data.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/ordered-data.h b/fs/btrfs/ordered-data.h
index 99e0853e4d3b..e60c07f36427 100644
--- a/fs/btrfs/ordered-data.h
+++ b/fs/btrfs/ordered-data.h
@@ -39,8 +39,8 @@ struct btrfs_ordered_sum {
*/
enum {
/*
- * Different types for direct io, one and only one of the 4 type can
- * be set when creating ordered extent.
+ * Different types for ordered extents, one and only one of the 4 types
+ * need to be set when creating ordered extent.
*
* REGULAR: For regular non-compressed COW write
* NOCOW: For NOCOW write into existing non-hole extent
--
2.30.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs: ordered-extent: fix comment for btrfs ordered extent flag bits
2021-02-11 8:14 [PATCH] btrfs: ordered-extent: fix comment for btrfs ordered extent flag bits Qu Wenruo
@ 2021-02-16 14:34 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2021-02-16 14:34 UTC (permalink / raw)
To: Qu Wenruo; +Cc: linux-btrfs
On Thu, Feb 11, 2021 at 04:14:05PM +0800, Qu Wenruo wrote:
> There is small error in comment about BTRFS_ORDERED_* flags.
>
> The 4 types are for ordered extent itself, not for direct io.
> Only 3 types support direct io, REGULAR/NOCOW/PREALLOC.
>
> Fix the comment to reflect that.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Added to misc-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-16 14:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-11 8:14 [PATCH] btrfs: ordered-extent: fix comment for btrfs ordered extent flag bits Qu Wenruo
2021-02-16 14:34 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox