Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Sidong Yang <realwakka@gmail.com>
To: linux-btrfs@vger.kernel.org
Subject: Simple question for comment in btrfs-progs qgroup code
Date: Sun, 21 Mar 2021 11:33:42 +0000	[thread overview]
Message-ID: <20210321113342.GA3319@realwakka> (raw)

Hello!

I see an comment in qgroup cmds below.

diff --git a/cmds/qgroup.c b/cmds/qgroup.c
index 2da83ffd..a71089e9 100644
--- a/cmds/qgroup.c
+++ b/cmds/qgroup.c
@@ -84,6 +84,7 @@ static int _cmd_qgroup_assign(const struct cmd_struct
*cmd, int assign,
	/*
	* FIXME src should accept subvol path
	*/

This comment is little confusing for me. src was parsed with
parse_qgroupid() and it also accepts subvol path. is it outdated
comment? or src should accept only lowest level of qgroup?

Thanks,
Sidong

             reply	other threads:[~2021-03-21 11:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-21 11:33 Sidong Yang [this message]
2021-03-22  1:14 ` Simple question for comment in btrfs-progs qgroup code Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210321113342.GA3319@realwakka \
    --to=realwakka@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox