From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Sidong Yang <realwakka@gmail.com>, linux-btrfs@vger.kernel.org
Subject: Re: Simple question for comment in btrfs-progs qgroup code
Date: Mon, 22 Mar 2021 09:14:17 +0800 [thread overview]
Message-ID: <9c8d9a67-e4fa-93b9-ba8a-d045156153ff@gmx.com> (raw)
In-Reply-To: <20210321113342.GA3319@realwakka>
On 2021/3/21 下午7:33, Sidong Yang wrote:
> Hello!
>
> I see an comment in qgroup cmds below.
>
> diff --git a/cmds/qgroup.c b/cmds/qgroup.c
> index 2da83ffd..a71089e9 100644
> --- a/cmds/qgroup.c
> +++ b/cmds/qgroup.c
> @@ -84,6 +84,7 @@ static int _cmd_qgroup_assign(const struct cmd_struct
> *cmd, int assign,
> /*
> * FIXME src should accept subvol path
> */
>
> This comment is little confusing for me. src was parsed with
> parse_qgroupid() and it also accepts subvol path. is it outdated
> comment? or src should accept only lowest level of qgroup?
It's outdated and confusing.
For the assign ioctl, it only accepts 3 u64 parameters,
assign:bool to indicate if it's adding or deleting qgroup relationship.
src/dst to specify the qgroupid (u64).
There is no room for path at all.
The qgroupid resolve is done completely in user space.
Feel free to delete the comment.
>
> Thanks,
> Sidong
>
prev parent reply other threads:[~2021-03-22 1:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 11:33 Simple question for comment in btrfs-progs qgroup code Sidong Yang
2021-03-22 1:14 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c8d9a67-e4fa-93b9-ba8a-d045156153ff@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=realwakka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox