public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v5 0/3] Index free space entries on size
Date: Mon, 22 Nov 2021 18:45:16 +0100	[thread overview]
Message-ID: <20211122174516.GL28560@twin.jikos.cz> (raw)
In-Reply-To: <cover.1637271014.git.josef@toxicpanda.com>

On Thu, Nov 18, 2021 at 04:33:13PM -0500, Josef Bacik wrote:
> v4->v5:
> - Broke out the self tests into their own patch.
> - Use the rb_add_cached() helper instead of yet again duplicating the rb tree
>   insertion code.
> 
> --- Original email ---
> 
> Hello,
> 
> I noticed while digging into an xfstests hang that the bytes index stuff was a
> little wonky when it came to bitmap entries.  If we change the ->bytes at all we
> weren't re-arranging the bytes indexed tree for bitmaps, because we don't do the
> unlink/link thing that we do with extent entries.
> 
> I fixed this particular shortcoming and added a new set of selftests to validate
> that everything was working as expected.  This uncovered a weirdness with how we
> handle ->max_extent_size, so I've added that as a separate patch to make it
> clear why the change is necessary.
> 
> Additionally I've updated my original patch to include the fixes necessary to
> make bitmaps re-index when they change.  I've added self tests to validate the
> changes to make sure everything is acting as we expect.  Thanks,
> 
> Josef
> 
> Josef Bacik (3):
>   btrfs: only use ->max_extent_size if it is set in the bitmap
>   btrfs: index free space entries on size
>   btrfs: add self test for bytes_index free space cache

Added to misc-next, thanks.

      parent reply	other threads:[~2021-11-22 17:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-18 21:33 [PATCH v5 0/3] Index free space entries on size Josef Bacik
2021-11-18 21:33 ` [PATCH v5 1/3] btrfs: only use ->max_extent_size if it is set in the bitmap Josef Bacik
2021-11-18 21:33 ` [PATCH v5 2/3] btrfs: index free space entries on size Josef Bacik
2021-11-19 10:52   ` Johannes Thumshirn
2021-11-19 15:37     ` Josef Bacik
2021-11-18 21:33 ` [PATCH v5 3/3] btrfs: add self test for bytes_index free space cache Josef Bacik
2021-11-22 17:45 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211122174516.GL28560@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox