Linux Btrfs filesystem development
 help / color / mirror / Atom feed
* [PATCH] btrfs: qgroup: Remove an oudated comment
@ 2022-02-10 12:52 Sidong Yang
  2022-02-10 18:59 ` David Sterba
  0 siblings, 1 reply; 3+ messages in thread
From: Sidong Yang @ 2022-02-10 12:52 UTC (permalink / raw)
  To: linux-btrfs; +Cc: Sidong Yang

It seems that btrfs_qgroup_inherit() works on subvolume creation and it
copies limits when BTRFS_QGROUP_INHERIT_SET_LIMITS flags on.

Signed-off-by: Sidong Yang <realwakka@gmail.com>
---
 fs/btrfs/qgroup.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index 8928275823a1..bfd45d52b1f5 100644
--- a/fs/btrfs/qgroup.c
+++ b/fs/btrfs/qgroup.c
@@ -30,7 +30,6 @@
  *  - reorganize keys
  *  - compressed
  *  - sync
- *  - copy also limits on subvol creation
  *  - limit
  *  - caches for ulists
  *  - performance benchmarks
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] btrfs: qgroup: Remove an oudated comment
  2022-02-10 12:52 [PATCH] btrfs: qgroup: Remove an oudated comment Sidong Yang
@ 2022-02-10 18:59 ` David Sterba
  2022-02-11 13:44   ` Sidong Yang
  0 siblings, 1 reply; 3+ messages in thread
From: David Sterba @ 2022-02-10 18:59 UTC (permalink / raw)
  To: Sidong Yang; +Cc: linux-btrfs

On Thu, Feb 10, 2022 at 12:52:04PM +0000, Sidong Yang wrote:
> It seems that btrfs_qgroup_inherit() works on subvolume creation and it
> copies limits when BTRFS_QGROUP_INHERIT_SET_LIMITS flags on.

I think we can delete the whole TODO comment from 2012.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] btrfs: qgroup: Remove an oudated comment
  2022-02-10 18:59 ` David Sterba
@ 2022-02-11 13:44   ` Sidong Yang
  0 siblings, 0 replies; 3+ messages in thread
From: Sidong Yang @ 2022-02-11 13:44 UTC (permalink / raw)
  To: dsterba, linux-btrfs

On Thu, Feb 10, 2022 at 07:59:06PM +0100, David Sterba wrote:
> On Thu, Feb 10, 2022 at 12:52:04PM +0000, Sidong Yang wrote:
> > It seems that btrfs_qgroup_inherit() works on subvolume creation and it
> > copies limits when BTRFS_QGROUP_INHERIT_SET_LIMITS flags on.
> 
> I think we can delete the whole TODO comment from 2012.

Agree. It's written very long ago. I'll write another patch to delete
it.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-02-11 13:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-10 12:52 [PATCH] btrfs: qgroup: Remove an oudated comment Sidong Yang
2022-02-10 18:59 ` David Sterba
2022-02-11 13:44   ` Sidong Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox