From: David Sterba <dsterba@suse.cz>
To: Su Yue <l@damenly.su>
Cc: Greg KH <greg@kroah.com>, Sasha Levin <sashal@kernel.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
David Sterba <dsterba@suse.com>,
clm@fb.com, josef@toxicpanda.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 5.10 16/27] btrfs: tree-checker: check item_size for dev_item
Date: Wed, 23 Feb 2022 18:20:58 +0100 [thread overview]
Message-ID: <20220223172058.GR12643@twin.jikos.cz> (raw)
In-Reply-To: <1r00qtxj.fsf@damenly.su>
On Fri, Feb 18, 2022 at 07:25:20PM +0800, Su Yue wrote:
> On Fri 18 Feb 2022 at 11:36, Greg KH <greg@kroah.com> wrote:
> > On Wed, Feb 09, 2022 at 01:40:52PM -0500, Sasha Levin wrote:
> \
> | ~~~~~~~~~~~~^
> fs/btrfs/ctree.h:1833:1: note: in expansion of macro
> \342\200\230BTRFS_SETGET_FUNCS\342\200\231
> 1833 | BTRFS_SETGET_FUNCS(item_size, struct btrfs_item, size,
> 32);
> | ^~~~~~~~~~~~~~~~~~
> ========================================================================
>
> The upstream patchset[1] merged in 5.17-rc1, changed second
> parameter
> of btrfs_item_size() from btrfs_item * to int directly.
> So yes, the backport is wrong.
>
> I'm not familiar with stable backport progress. Should I file a
> patch
> using btrfs_item *? Or just drop it?
>
> The patch is related to 0c982944af27d131d3b74242f3528169f66950ad
> but
> I wonder why the 0c98294 is not selected automatically.
We don't rely on the automatic selection, I evaluate all patches for
stable inclusion and add the CC: tag, this works well. Not all patches
need to go to stable, but AUTOSEL sometimes picks patches that could be
there and if it's not entirely wrong I don't object.
prev parent reply other threads:[~2022-02-23 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220209184103.47635-1-sashal@kernel.org>
2022-02-09 18:40 ` [PATCH AUTOSEL 5.10 16/27] btrfs: tree-checker: check item_size for dev_item Sasha Levin
2022-02-18 10:36 ` Greg KH
2022-02-18 11:25 ` Su Yue
2022-02-18 13:04 ` Greg KH
2022-02-23 17:20 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223172058.GR12643@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=greg@kroah.com \
--cc=josef@toxicpanda.com \
--cc=l@damenly.su \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox