From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 0/3] btrfs: scrub: big renaming to address the page and sector difference
Date: Mon, 14 Mar 2022 14:36:02 +0100 [thread overview]
Message-ID: <20220314133602.GK12643@twin.jikos.cz> (raw)
In-Reply-To: <cover.1647161284.git.wqu@suse.com>
On Sun, Mar 13, 2022 at 06:39:59PM +0800, Qu Wenruo wrote:
> [CHANGELOG]
> v2:
> - Rebased to misc-next directly, before scrub entrance refactor
> As this patchset is safer than entrance refactor.
>
> Minor conflicts due to scrub_remap() renaming.
>
> v3:
> - Get rid of the name "ssector", using "sector" directly.
> Previously we use names like "spage" to avoid confusion between MM
> layer page, and scrub page.
> But now since we rename it to scrub sector, and there is no naming
> conflicts, we are safe to use "sector" directly, without the eye
> hurting "ss".
>
> - Use names like "sectors" to replace "pagev"
> Which is more close to our latest naming schema.
>
> - Update involved comments to use latest style
>
> - Use bitshift to convert from sectors to bytes
With minor fixups added to misc-next, thanks.
I've seen some multiplications by sectorsize that's a local variable,
this could be also switched to use the bitshift.
prev parent reply other threads:[~2022-03-14 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 10:39 [PATCH v3 0/3] btrfs: scrub: big renaming to address the page and sector difference Qu Wenruo
2022-03-13 10:40 ` [PATCH v3 1/3] btrfs: scrub: rename members related to scrub_block::pagev Qu Wenruo
2022-03-14 13:22 ` David Sterba
2022-03-13 10:40 ` [PATCH v3 2/3] btrfs: scrub: rename scrub_page to scrub_sector Qu Wenruo
2022-03-13 10:40 ` [PATCH v3 3/3] btrfs: scrub: rename scrub_bio::pagev[] and related members Qu Wenruo
2022-03-14 13:36 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220314133602.GK12643@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox