public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v3 0/3] btrfs: scrub: big renaming to address the page and sector difference
Date: Sun, 13 Mar 2022 18:39:59 +0800	[thread overview]
Message-ID: <cover.1647161284.git.wqu@suse.com> (raw)

[CHANGELOG]
v2:
- Rebased to misc-next directly, before scrub entrance refactor
  As this patchset is safer than entrance refactor.

  Minor conflicts due to scrub_remap() renaming.

v3:
- Get rid of the name "ssector", using "sector" directly.
  Previously we use names like "spage" to avoid confusion between MM
  layer page, and scrub page.
  But now since we rename it to scrub sector, and there is no naming
  conflicts, we are safe to use "sector" directly, without the eye
  hurting "ss".

- Use names like "sectors" to replace "pagev"
  Which is more close to our latest naming schema.

- Update involved comments to use latest style

- Use bitshift to convert from sectors to bytes


This patchset can be cherry-picked from my github repo:
https://github.com/adam900710/linux/tree/refactor_scrub

They are the first 3 patches after misc-next.

From the ancient day, btrfs doesn't support sectorsize < PAGE_SIZE, thus
a lot of the old code consider one page == one sector, not only the
behavior, but also the naming.

This is no longer true after v5.16 since we have subpage support.

One of the worst location is scrub, we have tons of things named like
scrub_page, scrub_block::pagev, scrub_bio::pagev.

Even scrub for subpage is supported, the naming is not touched yet.

This patchset will first do the rename, providing the basis for later
scrub enhancement for subpage.

This patchset should not bring any behavior change.

Qu Wenruo (3):
  btrfs: scrub: rename members related to scrub_block::pagev
  btrfs: scrub: rename scrub_page to scrub_sector
  btrfs: scrub: rename scrub_bio::pagev[] and related members

 fs/btrfs/scrub.c | 693 +++++++++++++++++++++++------------------------
 1 file changed, 346 insertions(+), 347 deletions(-)

-- 
2.35.1


             reply	other threads:[~2022-03-13 10:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-13 10:39 Qu Wenruo [this message]
2022-03-13 10:40 ` [PATCH v3 1/3] btrfs: scrub: rename members related to scrub_block::pagev Qu Wenruo
2022-03-14 13:22   ` David Sterba
2022-03-13 10:40 ` [PATCH v3 2/3] btrfs: scrub: rename scrub_page to scrub_sector Qu Wenruo
2022-03-13 10:40 ` [PATCH v3 3/3] btrfs: scrub: rename scrub_bio::pagev[] and related members Qu Wenruo
2022-03-14 13:36 ` [PATCH v3 0/3] btrfs: scrub: big renaming to address the page and sector difference David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1647161284.git.wqu@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox