From: Christoph Hellwig <hch@lst.de>
To: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
Cc: Christoph Hellwig <hch@lst.de>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Qu Wenruo <wqu@suse.com>,
Naohiro Aota <naohiro.aota@wdc.com>,
linux-btrfs@vger.kernel.org
Subject: Re: fixes for handling of split direct I/O bios
Date: Thu, 24 Mar 2022 17:57:29 +0100 [thread overview]
Message-ID: <20220324165729.GA27778@lst.de> (raw)
In-Reply-To: <46203a49-0fde-aa5c-e92e-da0f1dd48885@dorminy.me>
On Thu, Mar 24, 2022 at 12:49:26PM -0400, Sweet Tea Dorminy wrote:
> I'm pretty new and don't know much about the criteria for cc'ing stable,
> but arguably this makes the check_data_csum() error message not lie about
> the start offset in such cases and it seems like a very low risk
> improvement to me... might it be worth adding a Fixes: tag / might this be
> a reasonable fix for stable?
The error message is the least of the problems - if there is an I/O
error or checksum mismatch this bug will make the repair not work.
next prev parent reply other threads:[~2022-03-24 16:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 16:06 fixes for handling of split direct I/O bios Christoph Hellwig
2022-03-24 16:06 ` [PATCH 1/2] btrfs: fix direct I/O read repair for split bios Christoph Hellwig
2022-03-30 14:43 ` David Sterba
2022-03-30 22:24 ` Qu Wenruo
2022-03-30 23:14 ` Qu Wenruo
2022-03-31 0:53 ` Qu Wenruo
2022-03-24 16:06 ` [PATCH 2/2] btrfs: fix direct I/O writes for split bios on zoned devices Christoph Hellwig
2022-03-24 16:49 ` fixes for handling of split direct I/O bios Sweet Tea Dorminy
2022-03-24 16:57 ` Christoph Hellwig [this message]
2022-03-25 9:14 ` Johannes Thumshirn
2022-03-29 8:00 ` Naohiro Aota
2022-04-08 16:40 ` Christoph Hellwig
2022-04-12 19:43 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220324165729.GA27778@lst.de \
--to=hch@lst.de \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=sweettea-kernel@dorminy.me \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox