Re: [Resend PATCH] generic: test fsync of directory with renamed symlink

[David Disseldorp <ddiss@suse.de>]

On Tue,  3 May 2022 11:57:49 +0100, fdmanana@kernel.org wrote:

> From: Filipe Manana <fdmanana@suse.com>
> 
> Test that if we fsync a directory, create a symlink inside it, rename
> the symlink, fsync again the directory and then power fail, after the
> filesystem is mounted again, the symlink exists with the new name and
> it has the correct content.
> 
> This currently fails on btrfs, because the symlink ends up empty (which
> is illegal on Linux), but it is fixed by kernel commit:
> 
>     d0e64a981fd841 ("btrfs: always log symlinks in full mode")
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

This looks fine and works for me.
Reviewed-by: David Disseldorp <ddiss@suse.de>

...
> +mkdir $SCRATCH_MNT/testdir

nit: It's worth quoting the variable here (and elsewhere). That said, I
highly doubt anyone is using a SCRATCH_MNT with a space in it, so it
should be okay as is.

Cheers, David