From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Wang Yugui <wangyugui@e16-tech.com>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/3] btrfs-progs: mkfs-tests/025: fix the wrong function call
Date: Wed, 5 Oct 2022 13:50:56 +0200 [thread overview]
Message-ID: <20221005115055.GK13389@suse.cz> (raw)
In-Reply-To: <3f0ff6ca-76f0-9e4c-7a3d-7c96ccafff57@gmx.com>
On Wed, Oct 05, 2022 at 03:58:47PM +0800, Qu Wenruo wrote:
> On 2022/10/5 14:43, Wang Yugui wrote:
> >> tests/mkfs-tests/025-zoned-parallel/test.sh | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tests/mkfs-tests/025-zoned-parallel/test.sh b/tests/mkfs-tests/025-zoned-parallel/test.sh
> >> index 8cad906cd5d1..83274bb23447 100755
> >> --- a/tests/mkfs-tests/025-zoned-parallel/test.sh
> >> +++ b/tests/mkfs-tests/025-zoned-parallel/test.sh
> >> @@ -8,7 +8,7 @@ source "$TEST_TOP/common"
> >> setup_root_helper
> >> prepare_test_dev
> >>
> >> -if !check_min_kernel_version 5.12; then
> >> +if ! check_min_kernel_version 5.12; then
> >> _notrun "zoned tests need kernel 5.12 and newer"
> >> fi
> >
> > '_notrun' should be changed to '_not_run' too.
>
> That's right, I forgot this as my previous patch would render the path
> unreachable for newer kernels.
>
> David, can you fix it when merging?
Fixed and pushed, thanks.
next prev parent reply other threads:[~2022-10-05 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 2:25 [PATCH 0/3] btrfs-progs: selftests fixes Qu Wenruo
2022-10-05 2:25 ` [PATCH 1/3] btrfs-progs: tests: fix the wrong kernel version check Qu Wenruo
2022-10-06 15:25 ` David Sterba
2022-10-05 2:25 ` [PATCH 2/3] btrfs-progs: mkfs-tests/025: fix the wrong function call Qu Wenruo
2022-10-05 6:43 ` Wang Yugui
2022-10-05 7:58 ` Qu Wenruo
2022-10-05 11:50 ` David Sterba [this message]
2022-10-05 2:25 ` [PATCH 3/3] btrfs-progs: convert-tests/022: add reiserfs support check Qu Wenruo
2022-10-06 15:29 ` David Sterba
2022-10-06 15:30 ` [PATCH 0/3] btrfs-progs: selftests fixes David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221005115055.GK13389@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wangyugui@e16-tech.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox