From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/3] btrfs-progs: selftests fixes
Date: Thu, 6 Oct 2022 17:30:31 +0200 [thread overview]
Message-ID: <20221006153031.GP13389@twin.jikos.cz> (raw)
In-Reply-To: <cover.1664936628.git.wqu@suse.com>
On Wed, Oct 05, 2022 at 10:25:11AM +0800, Qu Wenruo wrote:
> There are 3 bugs exposed during my tests for unified mkfs features, and
> they are all from the selftest itself:
>
> - check_min_kernel_version() doesn't handle 6.x kernels at all
> The original check never handles major number check properly.
> And when we change major number, returns in correct number now.
>
> - Missing a space between "!" and function call
> This bug is there for a long time.
>
> Without previous fix, one may incorrectly remove the "!" and cause
> new problems.
>
> - Convert/022 doesn't check if we have support for reiserfs
>
> Qu Wenruo (3):
> btrfs-progs: tests: fix the wrong kernel version check
> btrfs-progs: mkfs-tests/025: fix the wrong function call
> btrfs-progs: convert-tests/022: add reiserfs support check
I've foled patch 2 to the one that that introduced it so we don't have
broken tests. The other two merged to devel, thanks.
prev parent reply other threads:[~2022-10-06 15:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 2:25 [PATCH 0/3] btrfs-progs: selftests fixes Qu Wenruo
2022-10-05 2:25 ` [PATCH 1/3] btrfs-progs: tests: fix the wrong kernel version check Qu Wenruo
2022-10-06 15:25 ` David Sterba
2022-10-05 2:25 ` [PATCH 2/3] btrfs-progs: mkfs-tests/025: fix the wrong function call Qu Wenruo
2022-10-05 6:43 ` Wang Yugui
2022-10-05 7:58 ` Qu Wenruo
2022-10-05 11:50 ` David Sterba
2022-10-05 2:25 ` [PATCH 3/3] btrfs-progs: convert-tests/022: add reiserfs support check Qu Wenruo
2022-10-06 15:29 ` David Sterba
2022-10-06 15:30 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221006153031.GP13389@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox