From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: add comments for btrfs_map_block()
Date: Thu, 29 Jun 2023 18:02:43 +0200 [thread overview]
Message-ID: <20230629160243.GP16168@twin.jikos.cz> (raw)
In-Reply-To: <ZJsJRMQx3oNSaEOk@infradead.org>
On Tue, Jun 27, 2023 at 09:07:32AM -0700, Christoph Hellwig wrote:
> On Tue, Jun 27, 2023 at 03:34:31PM +0800, Qu Wenruo wrote:
> > + * @mirror_num_ret: (Mandatory) returned mirror number if the original
> > + * value is 0.
>
> This one is optional.
>
> > + *
> > + * @need_raid_map: (Deprecated) whether the map wants a full stripe map
> > + * (including all data and P/Q stripes) for RAID56.
> > + * Should always be 1 except for legacy call sites.
> > + */
>
> Saying deprecated for a paramter to function with just a few callers
> feels weird. For this patch I'd just stick to a functional description.
Agreed, I've updated the comment to refer to integrity checker instead
of 'deprecated'.
next prev parent reply other threads:[~2023-06-29 16:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 7:34 [PATCH] btrfs: add comments for btrfs_map_block() Qu Wenruo
2023-06-27 7:57 ` Qu Wenruo
2023-06-27 16:07 ` Christoph Hellwig
2023-06-27 22:00 ` Qu Wenruo
2023-06-28 4:59 ` Christoph Hellwig
2023-06-28 5:59 ` Qu Wenruo
2023-06-29 16:02 ` David Sterba [this message]
2023-06-29 15:37 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230629160243.GP16168@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox