From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Christoph Hellwig <hch@infradead.org>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: add comments for btrfs_map_block()
Date: Tue, 27 Jun 2023 21:59:45 -0700 [thread overview]
Message-ID: <ZJu+QbMPrvoqZpij@infradead.org> (raw)
In-Reply-To: <286ad810-f239-5fd8-92e3-fbf5f7c387a2@gmx.com>
On Wed, Jun 28, 2023 at 06:00:56AM +0800, Qu Wenruo wrote:
> Really it's btrfsic_map_block() the only exception.
>
> > Maybe add a follow on patch to just
> > remove the paramter and waste the little bit of extra effort to build
> > the raid map for btrfsic_map_block?
> >
>
> Well, I'd prefer to remove btrfsic_map_block() and the check_int thing
> completely.
I'm perfectly fine with removing it. But I don't see why that needs
to delay dropping the raid_map argument.
next prev parent reply other threads:[~2023-06-28 7:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 7:34 [PATCH] btrfs: add comments for btrfs_map_block() Qu Wenruo
2023-06-27 7:57 ` Qu Wenruo
2023-06-27 16:07 ` Christoph Hellwig
2023-06-27 22:00 ` Qu Wenruo
2023-06-28 4:59 ` Christoph Hellwig [this message]
2023-06-28 5:59 ` Qu Wenruo
2023-06-29 16:02 ` David Sterba
2023-06-29 15:37 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJu+QbMPrvoqZpij@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox