From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Naohiro Aota <Naohiro.Aota@wdc.com>
Subject: Re: [PATCH 2/5] btrfs: zoned: don't clear dirty flag of extent buffer
Date: Tue, 21 Nov 2023 18:03:27 +0100 [thread overview]
Message-ID: <20231121170327.GB19695@lst.de> (raw)
In-Reply-To: <20231121-josef-generic-163-v1-2-049e37185841@wdc.com>
> if (test_bit(EXTENT_BUFFER_CANCELLED, &eb->bflags)) {
> - WARN_ON_ONCE(found_start != 0);
> + memzero_extent_buffer(eb, 0, eb->len);
> return BLK_STS_OK;
> + if (btrfs_is_zoned(fs_info)) {
> + set_bit(EXTENT_BUFFER_CANCELLED, &eb->bflags);
> + return;
> + }
Maybe these two places would benefit from comments on why the buffer
is just marked as cancelled and zeroed out (that is to keep the
write order because block numbers are already assigned)?
Otherwise this looks great:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-11-21 17:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 16:32 [PATCH 0/5] btrfs: zoned: remove extent_buffer redirtying Johannes Thumshirn
2023-11-21 16:32 ` [PATCH 1/5] btrfs: rename EXTENT_BUFFER_NO_CHECK to EXTENT_BUFFER_CANCELLED Johannes Thumshirn
2023-11-21 17:02 ` Christoph Hellwig
2023-11-22 13:20 ` David Sterba
2023-11-22 13:57 ` Johannes Thumshirn
2023-11-21 16:32 ` [PATCH 2/5] btrfs: zoned: don't clear dirty flag of extent buffer Johannes Thumshirn
2023-11-21 17:03 ` Christoph Hellwig [this message]
2023-11-21 16:32 ` [PATCH 3/5] btrfs: remove now unneeded btrfs_redirty_list_add Johannes Thumshirn
2023-11-21 17:03 ` Christoph Hellwig
2023-11-21 16:32 ` [PATCH 4/5] btrfs: use memset_page instead of opencoding it Johannes Thumshirn
2023-11-21 17:04 ` Christoph Hellwig
2023-11-21 16:32 ` [PATCH 5/5] btrfs: reflow btrfs_free_tree_block Johannes Thumshirn
2023-11-21 17:04 ` Christoph Hellwig
2023-11-21 21:01 ` [PATCH 0/5] btrfs: zoned: remove extent_buffer redirtying Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121170327.GB19695@lst.de \
--to=hch@lst.de \
--cc=Naohiro.Aota@wdc.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox