From: David Sterba <dsterba@suse.cz>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Naohiro Aota <Naohiro.Aota@wdc.com>
Subject: Re: [PATCH 1/5] btrfs: rename EXTENT_BUFFER_NO_CHECK to EXTENT_BUFFER_CANCELLED
Date: Wed, 22 Nov 2023 14:20:10 +0100 [thread overview]
Message-ID: <20231122132010.GY11264@twin.jikos.cz> (raw)
In-Reply-To: <20231121-josef-generic-163-v1-1-049e37185841@wdc.com>
On Tue, Nov 21, 2023 at 08:32:30AM -0800, Johannes Thumshirn wrote:
> EXTENT_BUFFER_CANCELLED better describes the state of the extent buffer,
> namely its writeout has been cancelled.
I've read the patches a few times and still can't see how the meaning of
'cancelled' fits. It's about cancelling write out yes, but I don't see
anywhere explained why and why the eb is zeroed. This could be put next
to the enum definition or to function that does the main part of the
logic. You can also rename it to CANCELLED_WRITEOUT or use _ZONED_ in
the name so it's clear that it has a special purpose etc, but as it is
now I think it should be improved.
next prev parent reply other threads:[~2023-11-22 13:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 16:32 [PATCH 0/5] btrfs: zoned: remove extent_buffer redirtying Johannes Thumshirn
2023-11-21 16:32 ` [PATCH 1/5] btrfs: rename EXTENT_BUFFER_NO_CHECK to EXTENT_BUFFER_CANCELLED Johannes Thumshirn
2023-11-21 17:02 ` Christoph Hellwig
2023-11-22 13:20 ` David Sterba [this message]
2023-11-22 13:57 ` Johannes Thumshirn
2023-11-21 16:32 ` [PATCH 2/5] btrfs: zoned: don't clear dirty flag of extent buffer Johannes Thumshirn
2023-11-21 17:03 ` Christoph Hellwig
2023-11-21 16:32 ` [PATCH 3/5] btrfs: remove now unneeded btrfs_redirty_list_add Johannes Thumshirn
2023-11-21 17:03 ` Christoph Hellwig
2023-11-21 16:32 ` [PATCH 4/5] btrfs: use memset_page instead of opencoding it Johannes Thumshirn
2023-11-21 17:04 ` Christoph Hellwig
2023-11-21 16:32 ` [PATCH 5/5] btrfs: reflow btrfs_free_tree_block Johannes Thumshirn
2023-11-21 17:04 ` Christoph Hellwig
2023-11-21 21:01 ` [PATCH 0/5] btrfs: zoned: remove extent_buffer redirtying Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122132010.GY11264@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=Naohiro.Aota@wdc.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox