From: David Sterba <dsterba@suse.cz>
To: Filipe Manana <fdmanana@kernel.org>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 7/8] btrfs: use a dedicated data structure for chunk maps
Date: Tue, 21 Nov 2023 19:08:51 +0100 [thread overview]
Message-ID: <20231121180851.GT11264@twin.jikos.cz> (raw)
In-Reply-To: <CAL3q7H6sb+N86AFiSuK1+qJU0LGBSGRM0LXHmdPGW_Ff5AMUyg@mail.gmail.com>
On Tue, Nov 21, 2023 at 04:50:07PM +0000, Filipe Manana wrote:
> On Tue, Nov 21, 2023 at 3:26 PM David Sterba <dsterba@suse.cz> wrote:
> > On Tue, Nov 21, 2023 at 01:38:38PM +0000, fdmanana@kernel.org wrote:
> > > From: Filipe Manana <fdmanana@suse.com>
> > > fs/btrfs/disk-io.c | 7 +-
> > > fs/btrfs/extent_map.c | 46 ---
> > > fs/btrfs/extent_map.h | 4 -
> > > fs/btrfs/fs.h | 3 +-
> > > fs/btrfs/inode.c | 25 +-
> > > fs/btrfs/raid56.h | 2 +-
> > > fs/btrfs/scrub.c | 39 +--
> > > fs/btrfs/tests/btrfs-tests.c | 3 +-
> > > fs/btrfs/tests/btrfs-tests.h | 1 +
> > > fs/btrfs/tests/extent-map-tests.c | 40 +--
> > > fs/btrfs/volumes.c | 540 ++++++++++++++++++------------
> > > fs/btrfs/volumes.h | 45 ++-
> > > fs/btrfs/zoned.c | 24 +-
> >
> > I see a lot of errors when compiling zoned.c, there are still map_lookup
> > structures. Do you have the zoned mode config option enabled?
>
> It misses this hunk: https://pastebin.com/raw/mr1KMZ8N
>
> Do you want me to send a v2, or do you prefer to fix it up?
Simple enough to apply, no need to resend, thanks.
next prev parent reply other threads:[~2023-11-21 18:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 13:38 [PATCH 0/8] btrfs: add a btrfs_chunk_map structure and preparatory cleanups fdmanana
2023-11-21 13:38 ` [PATCH 1/8] btrfs: fix off-by-one when checking chunk map includes logical address fdmanana
2023-11-21 13:38 ` [PATCH 2/8] btrfs: make error messages more clear when getting a chunk map fdmanana
2023-11-21 13:38 ` [PATCH 3/8] btrfs: mark sanity checks when getting chunk map as unlikely fdmanana
2023-11-21 13:38 ` [PATCH 4/8] btrfs: split assert into two different asserts when removing block group fdmanana
2023-11-21 13:38 ` [PATCH 5/8] btrfs: unexport extent_map_block_end() fdmanana
2023-11-21 13:38 ` [PATCH 6/8] btrfs: use btrfs_next_item() at scrub.c:find_first_extent_item() fdmanana
2023-11-21 13:38 ` [PATCH 7/8] btrfs: use a dedicated data structure for chunk maps fdmanana
2023-11-21 15:19 ` David Sterba
2023-11-21 16:50 ` Filipe Manana
2023-11-21 18:08 ` David Sterba [this message]
2023-11-21 18:23 ` David Sterba
2023-11-22 11:32 ` Filipe Manana
2023-11-22 14:16 ` David Sterba
2023-11-21 21:25 ` kernel test robot
2023-11-21 13:38 ` [PATCH 8/8] btrfs: remove stripe size local variable from insert_dev_extents() fdmanana
2023-11-21 14:12 ` [PATCH 0/8] btrfs: add a btrfs_chunk_map structure and preparatory cleanups Josef Bacik
2023-11-21 21:03 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121180851.GT11264@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox