From: Josef Bacik <josef@toxicpanda.com>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: migrate extent_buffer::pages[] to folio
Date: Mon, 27 Nov 2023 11:32:36 -0500 [thread overview]
Message-ID: <20231127163236.GF2366036@perftesting> (raw)
In-Reply-To: <b87c95b697347980b008d8140ceec49590af4f5d.1701037103.git.wqu@suse.com>
On Mon, Nov 27, 2023 at 08:48:45AM +1030, Qu Wenruo wrote:
> For now extent_buffer::pages[] are still only accept single page
> pointer, thus we can migrate to folios pretty easily.
>
> As for single page, page and folio are 1:1 mapped.
>
> This patch would just do the conversion from struct page to struct
> folio, providing the first step to higher order folio in the future.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
This doesn't apply to misc-next cleanly, so I can't do my normal review, but
just swapping us over to the folio stuff in name everywhere is a valuable first
start. I'd like to see this run through our testing infrastructure to make sure
nothing got missed. Once you can get it to apply cleanly somewhere and validate
nothing weird got broken you can add
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
next prev parent reply other threads:[~2023-11-27 16:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 22:18 [PATCH] btrfs: migrate extent_buffer::pages[] to folio Qu Wenruo
2023-11-27 16:32 ` Josef Bacik [this message]
2023-11-27 22:17 ` Qu Wenruo
2023-11-29 16:02 ` David Sterba
2023-11-30 6:56 ` Qu Wenruo
2023-11-30 12:19 ` Neal Gompa
2023-11-30 21:04 ` Qu Wenruo
2023-11-30 23:18 ` David Sterba
2023-11-30 23:33 ` Qu Wenruo
2023-11-30 23:22 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127163236.GF2366036@perftesting \
--to=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox